[don't merge] Various updates#5
Closed
theacodes wants to merge 14 commits intoGoogleCloudPlatform:masterfrom
Closed
[don't merge] Various updates#5theacodes wants to merge 14 commits intoGoogleCloudPlatform:masterfrom
theacodes wants to merge 14 commits intoGoogleCloudPlatform:masterfrom
Conversation
theacodes
commented
Sep 3, 2015
- Removing custom docker image and moving to new python runtime in testing. The docker image location is temporary.
- Less hacky entrpoint thanks to the new runtime activating virtualenv automatically.
- Removing resource and scaling configuration from app.yaml and worker.yaml.
- Removing unused env variables from app.yaml and worker.yaml
- Deleted oauth2 and switched to oauth2client's built-in flask_util.
- Added logout view to bookshelf/init.py
- Added authorization callback request_user_info to bookshelf/init.py to grab the user's google+ profile.
- Removed logging code and dropped down to just performing basic setup for the built-in loggin module.
- Upgraded gcloud to 0.7.1 and fixed storage.
- Significantly reduced the amount of code in main.py - it now just handles creating the app, exposing the queue, and running the app locally. Running the app live is handled by gunicorn in procfile.
- Removed the /_ah/stop handler from monitor, as it doesn't work as expected and interrupt signals are sent to the app anyways.
…_list Add Missing List Region Tag (for 2-structured-data)
…-7-gce Update Deploy scripts for gcloud changes
Contributor
|
Code looks great. Only small issue I've seen is that it seems test_crud.testListByUser has broken because the way you fake the oauth2 credentials doesn't work anymore. |
5fbbe23 to
bed8d19
Compare
Author
|
@waprin test fixed and a temporary full dockerfile has been added while we wait for the new python runtime. Do you think this looks good to merge and apply across branches? |
* Removing custom docker image and moving to new python runtime in testing. The docker image location is temporary. * Less hacky entrpoint thanks to the new runtime activating virtualenv automatically. * Removing resource and scaling configuration from app.yaml and worker.yaml. * Removing unused env variables from app.yaml and worker.yaml * Deleted oauth2 and switched to oauth2client's built-in flask_util. * Added logout view to bookshelf/__init__.py * Added authorization callback request_user_info to bookshelf/__init__.py to grab the user's google+ profile. * Removed logging code and dropped down to just performing basic setup for the built-in loggin module. * Upgraded gcloud to 0.7.1 and fixed storage. * Significantly reduced the amount of code in main.py - it now just handles creating the app, exposing the queue, and running the app locally. Running the app live is handled by gunicorn in procfile. * Removed the /_ah/stop handler from monitor, as it doesn't work as expected and interrupt signals are sent to the app anyways.
Contributor
|
Yep LGTM |
Author
|
I now have to figure out how to appropriately apply this to ... every branch. :( |
Contributor
|
If you want to divide the branches I can do half of them. |
Author
|
Let me think on it. None of these updates are critical yet. |
Author
|
I'm going to rewrite the history on this repository and push all new branches. I feel this is the best way to handle an update this big. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.