Skip to content

[don't merge] Various updates#5

Closed
theacodes wants to merge 14 commits intoGoogleCloudPlatform:masterfrom
theacodes:master
Closed

[don't merge] Various updates#5
theacodes wants to merge 14 commits intoGoogleCloudPlatform:masterfrom
theacodes:master

Conversation

@theacodes
Copy link
Copy Markdown

  • Removing custom docker image and moving to new python runtime in testing. The docker image location is temporary.
  • Less hacky entrpoint thanks to the new runtime activating virtualenv automatically.
  • Removing resource and scaling configuration from app.yaml and worker.yaml.
  • Removing unused env variables from app.yaml and worker.yaml
  • Deleted oauth2 and switched to oauth2client's built-in flask_util.
  • Added logout view to bookshelf/init.py
  • Added authorization callback request_user_info to bookshelf/init.py to grab the user's google+ profile.
  • Removed logging code and dropped down to just performing basic setup for the built-in loggin module.
  • Upgraded gcloud to 0.7.1 and fixed storage.
  • Significantly reduced the amount of code in main.py - it now just handles creating the app, exposing the queue, and running the app locally. Running the app live is handled by gunicorn in procfile.
  • Removed the /_ah/stop handler from monitor, as it doesn't work as expected and interrupt signals are sent to the app anyways.

@waprin
Copy link
Copy Markdown
Contributor

waprin commented Sep 3, 2015

Code looks great. Only small issue I've seen is that it seems test_crud.testListByUser has broken because the way you fake the oauth2 credentials doesn't work anymore.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Sep 4, 2015
@theacodes theacodes force-pushed the master branch 2 times, most recently from 5fbbe23 to bed8d19 Compare September 4, 2015 20:19
@theacodes
Copy link
Copy Markdown
Author

@waprin test fixed and a temporary full dockerfile has been added while we wait for the new python runtime. Do you think this looks good to merge and apply across branches?

* Removing custom docker image and moving to new python runtime in testing. The docker image location is temporary.
* Less hacky entrpoint thanks to the new runtime activating virtualenv automatically.
* Removing resource and scaling configuration from app.yaml and worker.yaml.
* Removing unused env variables from app.yaml and worker.yaml
* Deleted oauth2 and switched to oauth2client's built-in flask_util.
* Added logout view to bookshelf/__init__.py
* Added authorization callback request_user_info to bookshelf/__init__.py to grab the user's google+ profile.
* Removed logging code and dropped down to just performing basic setup for the built-in loggin module.
* Upgraded gcloud to 0.7.1 and fixed storage.
* Significantly reduced the amount of code in main.py - it now just handles creating the app, exposing the queue, and running the app locally. Running the app live is handled by gunicorn in procfile.
* Removed the /_ah/stop handler from monitor, as it doesn't work as expected and interrupt signals are sent to the app anyways.
@waprin
Copy link
Copy Markdown
Contributor

waprin commented Sep 4, 2015

Yep LGTM

@theacodes
Copy link
Copy Markdown
Author

I now have to figure out how to appropriately apply this to ... every branch. :(

@waprin
Copy link
Copy Markdown
Contributor

waprin commented Sep 4, 2015

If you want to divide the branches I can do half of them.

@theacodes
Copy link
Copy Markdown
Author

Let me think on it. None of these updates are critical yet.

@theacodes
Copy link
Copy Markdown
Author

I'm going to rewrite the history on this repository and push all new branches. I feel this is the best way to handle an update this big.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants