Conversation
netdpb
reviewed
Aug 8, 2019
| Automatic-Module-Name: com.google.api.client | ||
| ``` | ||
|
|
||
| The module name should be globally unique and composed of |
Contributor
There was a problem hiding this comment.
Might want to link to Stephen Colebourne's discussion of module naming best practices, and even recommend more strongly that we follow them (Replace "often has the same name" with "should have the same name", etc.).
Contributor
Author
There was a problem hiding this comment.
changed to "should" as suggested
@garrettjonesgoogle What do you think about linking to othe non-normative references?
Contributor
There was a problem hiding this comment.
@elharo I don't have a fundamental problem with it.
netdpb
approved these changes
Aug 8, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@netdpb @garrettjonesgoogle
fixes #832
First draft. Also see googleapis/google-http-java-client#782