ДЗ2#830
Open
Stvaik wants to merge 11 commits into
Open
Conversation
GefMar
reviewed
Aug 17, 2019
| list_1 = [1, 3, 5, 8, 9] | ||
| list_2 = [1, 7, 4, 15, 9] | ||
| list_1.pop(0) | ||
| list_1.pop(3) |
There was a problem hiding this comment.
А если список изменится? Надо чтоб программа проверяла
GefMar
reviewed
Aug 21, 2019
| pass | ||
|
|
||
| def my_round(number, digits): | ||
| multiplier = pow(10.0, digits) |
There was a problem hiding this comment.
А ведь в условии сказано не использовать встроенные функции, это относится и к функции pow
|
|
||
| def lucky_ticket(ticket_number): | ||
| pass | ||
| lucky_ticket = lambda x :(lambda x : 'yes' if sum(x[:3]) == sum(x[3:]) else 'no')(map(int, list(str(x)))) |
There was a problem hiding this comment.
В таких задачах желательно чтоб функция возвращала булевое
GefMar
reviewed
Sep 2, 2019
| import math | ||
| class Triangle: | ||
| def __init__(self, A, B, C): | ||
| def sideLen(dot1, dot2): |
| self.AB = sideLen(self.A, self.B) | ||
| self.BC = sideLen(self.B, self.C) | ||
| self.CA = sideLen(self.C, self.A) | ||
| def areaTriangle(self): |
There was a problem hiding this comment.
Именование методов как и функции snake_case
| self.patronymic = patronymic | ||
|
|
||
| def get_full_name(self): | ||
| return self.name + ' ' + self.patronymic + ' ' + self.surname |
There was a problem hiding this comment.
Лучше через форматирование, будет более явно и исключается ошибка типов
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.