Repository navigation
Gomboc CLI Scan - Azure/Terraform - #3
Open
gomboc-ai-dev-gcp[bot] wants to merge 2 commits into
Open
gomboc-ai-dev-gcp[bot] wants to merge 2 commits into
gomboc-ai-dev-gcp[bot] wants to merge 2 commits into
Conversation
| source_address_prefixes = var.ip_whitelist | ||
| destination_address_prefix = "*" | ||
| } | ||
| tags = "null" |
Author
There was a problem hiding this comment.
l.165Recommended applying Resource Tags:- Gomboc Best Practices CIS Critical Security Controls v8.1 (Azure)
- CIS Critical Security Controls v8.1
| account_replication_type = "LRS" | ||
| account_tier = "Standard" | ||
| min_tls_version = "TLS1_2" | ||
| infrastructure_encryption_enabled = true |
Author
There was a problem hiding this comment.
l.214Recommended applying Encryption At-Rest with Provider Managed Key:- Gomboc Best Practices NIST 2.0.0 (Azure)
- NIST 2.0.0
| account_tier = "Standard" | ||
| min_tls_version = "TLS1_2" | ||
| infrastructure_encryption_enabled = true | ||
| allow_nested_items_to_be_public = false |
Author
There was a problem hiding this comment.
l.215Recommended applying Ensure 'Allow public access from any Azure service within Azure to this server' for PostgreSQL flexible server is disabled:- CIS Microsoft Azure Foundations v3.0.0
- CIS Critical Security Controls v8.1
| min_tls_version = "TLS1_2" | ||
| infrastructure_encryption_enabled = true | ||
| allow_nested_items_to_be_public = false | ||
| public_network_access_enabled = false |
Author
There was a problem hiding this comment.
l.216Recommended applying Ensure 'Allow public access from any Azure service within Azure to this server' for PostgreSQL flexible server is disabled:- CIS Microsoft Azure Foundations v3.0.0
- CIS Critical Security Controls v8.1
| infrastructure_encryption_enabled = true | ||
| allow_nested_items_to_be_public = false | ||
| public_network_access_enabled = false | ||
| https_traffic_only_enabled = true |
Author
There was a problem hiding this comment.
l.217Recommended applying HTTPS:- Gomboc Best Practices CIS Critical Security Controls v8.1 (Azure)
| allow_nested_items_to_be_public = false | ||
| public_network_access_enabled = false | ||
| https_traffic_only_enabled = true | ||
| tags = "null" |
Author
There was a problem hiding this comment.
l.218Recommended applying Resource Tags:- Gomboc Best Practices CIS Critical Security Controls v8.1 (Azure)
- CIS Critical Security Controls v8.1
| https_traffic_only_enabled = true | ||
| tags = "null" | ||
| blob_properties { | ||
| versioning_enabled = true |
Author
There was a problem hiding this comment.
l.220Recommended applying Data Versioning:- Gomboc Best Practices NIST 2.0.0 (Azure)
- NIST 2.0.0
| blob_properties { | ||
| versioning_enabled = true | ||
| delete_retention_policy { | ||
| permanent_delete_enabled = false |
Author
There was a problem hiding this comment.
l.222Recommended applying Deletion Protection:- Gomboc Best Practices CIS Critical Security Controls v8.1 (Azure)
- CIS Critical Security Controls v8.1
| } | ||
| queue_properties { | ||
| logging { | ||
| read = true |
Author
There was a problem hiding this comment.
l.227Recommended applying Security Logs:- Gomboc Best Practices CIS Critical Security Controls v8.1 (Azure)
| queue_properties { | ||
| logging { | ||
| read = true | ||
| delete = true |
Author
There was a problem hiding this comment.
l.228Recommended applying Security Logs:- Gomboc Best Practices CIS Critical Security Controls v8.1 (Azure)
| logging { | ||
| read = true | ||
| delete = true | ||
| write = true |
Author
There was a problem hiding this comment.
l.229Recommended applying Security Logs:- Gomboc Best Practices CIS Critical Security Controls v8.1 (Azure)
| write = true | ||
| } | ||
| minute_metrics { | ||
| retention_policy_days = "30" |
Author
There was a problem hiding this comment.
l.232Recommended applying Expiry:- Gomboc Best Practices CIS Critical Security Controls v8.1 (Azure)
| vm_size = "Standard_DS1_v2" | ||
|
|
||
| delete_os_disk_on_termination = true | ||
| delete_os_disk_on_termination = false |
Author
There was a problem hiding this comment.
l.245Recommended applying Deletion Protection:- Gomboc Best Practices CIS Critical Security Controls v8.1 (Azure)
- CIS Critical Security Controls v8.1
| tags = { | ||
| role = "logger" | ||
| } | ||
| delete_data_disks_on_termination = false |
Author
There was a problem hiding this comment.
l.311Recommended applying Deletion Protection:- Gomboc Best Practices CIS Critical Security Controls v8.1 (Azure)
- CIS Critical Security Controls v8.1
| vm_size = "Standard_D1_v2" | ||
|
|
||
| delete_os_disk_on_termination = true | ||
| delete_os_disk_on_termination = false |
Author
There was a problem hiding this comment.
l.421Recommended applying Deletion Protection:- Gomboc Best Practices CIS Critical Security Controls v8.1 (Azure)
- CIS Critical Security Controls v8.1
| tags = { | ||
| role = "dc" | ||
| } | ||
| delete_data_disks_on_termination = false |
Author
There was a problem hiding this comment.
l.468Recommended applying Deletion Protection:- Gomboc Best Practices CIS Critical Security Controls v8.1 (Azure)
- CIS Critical Security Controls v8.1
| vm_size = "Standard_D1_v2" | ||
|
|
||
| delete_os_disk_on_termination = true | ||
| delete_os_disk_on_termination = false |
Author
There was a problem hiding this comment.
l.500Recommended applying Deletion Protection:- Gomboc Best Practices CIS Critical Security Controls v8.1 (Azure)
- CIS Critical Security Controls v8.1
| tags = { | ||
| role = "wef" | ||
| } | ||
| delete_data_disks_on_termination = false |
Author
There was a problem hiding this comment.
l.548Recommended applying Deletion Protection:- Gomboc Best Practices CIS Critical Security Controls v8.1 (Azure)
- CIS Critical Security Controls v8.1
| vm_size = "Standard_D1_v2" | ||
|
|
||
| delete_os_disk_on_termination = true | ||
| delete_os_disk_on_termination = false |
Author
There was a problem hiding this comment.
l.581Recommended applying Deletion Protection:- Gomboc Best Practices CIS Critical Security Controls v8.1 (Azure)
- CIS Critical Security Controls v8.1
| tags = { | ||
| role = "win10" | ||
| } | ||
| delete_data_disks_on_termination = false |
Author
There was a problem hiding this comment.
l.629Recommended applying Deletion Protection:- Gomboc Best Practices CIS Critical Security Controls v8.1 (Azure)
- CIS Critical Security Controls v8.1
| } | ||
| */ | ||
| resource "azurerm_storage_encryption_scope" "my_azurerm_storage_encryption_scope_azurerm_storage_account_detectionlab-storageaccount" { | ||
| storage_account_id = azurerm_storage_account.detectionlab-storageaccount.id |
Author
There was a problem hiding this comment.
l.667Recommended applying Encryption At-Rest with Bespoke Service Implementation:- Gomboc Best Practices NIST 2.0.0 (Azure)
- NIST 2.0.0
| */ | ||
| resource "azurerm_storage_encryption_scope" "my_azurerm_storage_encryption_scope_azurerm_storage_account_detectionlab-storageaccount" { | ||
| storage_account_id = azurerm_storage_account.detectionlab-storageaccount.id | ||
| source = "Microsoft.Storage" |
Author
There was a problem hiding this comment.
l.668Recommended applying Encryption At-Rest with Bespoke Service Implementation:- Gomboc Best Practices NIST 2.0.0 (Azure)
- NIST 2.0.0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fix was produced in response to a scan request in the Gomboc Portal on the following target:
A complete log of the request can be found here.
These recommendations come from the following benchmarks
View the details on Gomboc's Portal