fix: title normalization in duplicate detection (#948)#8654
Open
vonguyenkhang wants to merge 1 commit intoFreshRSS:edgefrom
Open
fix: title normalization in duplicate detection (#948)#8654vonguyenkhang wants to merge 1 commit intoFreshRSS:edgefrom
vonguyenkhang wants to merge 1 commit intoFreshRSS:edgefrom
Conversation
Standardize entry titles (HTML, case, whitespace) before checking for duplicates in feeds and categories.
Member
|
Could you please try to provide:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Standardize entry titles (HTML, case, whitespace) before checking for duplicates in feeds and categories.
Without these changes, some users reported "hit or miss" behaviour after enabling
Mark an article as read… if an identical title already exists in the top n newest articles of the category(#948 (comment), #948 (comment), #948 (comment)).Closes #
Changes proposed in this pull request:
FreshRSS_Entry::normalizeTitle()to decode HTML entities, collapse whitespace, and lowercase strings.$titlesAsReadlookup in both Feed and Category scopes.How to test the feature manually:
then paste URL of "RNZ World Headlines" feed. Use default settings for Article unicity criteria.
Repeat for "RNZ New Zealand Headlines".
Pull request checklist:
Additional information can be found in the documentation.