Skip to content

Fix all mislabel cancel button#8615

Open
matheusroberson wants to merge 3 commits intoFreshRSS:edgefrom
matheusroberson:fix-cancel-button-text
Open

Fix all mislabel cancel button#8615
matheusroberson wants to merge 3 commits intoFreshRSS:edgefrom
matheusroberson:fix-cancel-button-text

Conversation

@matheusroberson
Copy link
Copy Markdown
Contributor

  • Change gen.action.cancel to gen.action.reset
  • Create gen.action.reset using make for all languanges
  • Add a line in CREDITS.md

Closes #3662

Changes proposed in this pull request:

  • Change mislabel cancel button to reset button

How to test the feature manually:

  1. go to manage extension or another page which had cancel button
  2. open the extension settings panel

Pull request checklist:

  • clear commit messages
  • code manually tested
  • unit tests written (optional if too hard)
  • documentation updated

Additional information can be found in the documentation.

@Frenzie
Copy link
Copy Markdown
Member

Frenzie commented Mar 18, 2026

UI-wise I'd prefer it to be actual cancel, rather than introducing a new string for what's a dispreferred action in the first place.

@matheusroberson
Copy link
Copy Markdown
Contributor Author

UI-wise I'd prefer it to be actual cancel, rather than introducing a new string for what's a dispreferred action in the first place.

I'm not entirely sure how this would behave on pages like Configuration > Display. Would it close the page and return to the home screen?

@Frenzie
Copy link
Copy Markdown
Member

Frenzie commented Mar 19, 2026

I'd remove it altogether, but going back is an option too.

@matheusroberson
Copy link
Copy Markdown
Contributor Author

I'd remove it altogether, but going back is an option too.

I agree with removing it altogether, but it seems appropriate to keep it on the “Manage Extensions” page, as it’s quite useful for extensions like UserCSS and UserJS.

* Change gen.action.cancel to gen.action.reset
* Create gen.action.reset using make for all languanges
* Add a line in CREDITS.md
@matheusroberson matheusroberson force-pushed the fix-cancel-button-text branch from ce67405 to 8924891 Compare March 19, 2026 14:20
@Frenzie
Copy link
Copy Markdown
Member

Frenzie commented Mar 19, 2026

Yes, but there it should function as cancel/close (same as pressing escape or clicking next to it) rather than reset. :-)

@Frenzie
Copy link
Copy Markdown
Member

Frenzie commented Mar 19, 2026

PS You might potentially want to hold off on implementing my suggestions for a little bit since other people might have different ideas, depending on how involved it is.

@Alkarex Alkarex added this to the 1.29.0 milestone Mar 30, 2026
@Alkarex
Copy link
Copy Markdown
Member

Alkarex commented Mar 30, 2026

I am not sure I understand the problem with Cancel. Can you please explain again @Frenzie ?
And shouldn’t we just rename the key gen.action.cancel to gen.action.reset? No reason to keep the old one, is there?

@Frenzie
Copy link
Copy Markdown
Member

Frenzie commented Mar 30, 2026

I am not sure I understand the problem with Cancel. Can you please explain again @Frenzie ?

That depends which problem you mean.

  1. The text that says cancel actually does reset.
  2. Is there ever anybody who actually wants reset?
  3. There are some dialogs you can't exit because of this problem. Making the text say "reset" won't fix this fundamental issue.

In short, I consider cancel the correct text and behavior. It's just that the behavior is currently broken.

@Inverle
Copy link
Copy Markdown
Member

Inverle commented Apr 1, 2026

And shouldn’t we just rename the key gen.action.cancel to gen.action.reset? No reason to keep the old one, is there?

Extensions would still be using gen.action.cancel in their configure.phtml, until they are updated, so it shouldn't be removed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] Manage extension: Cancel button does not close the settings panel

4 participants