Fix all mislabel cancel button#8615
Conversation
|
UI-wise I'd prefer it to be actual cancel, rather than introducing a new string for what's a dispreferred action in the first place. |
I'm not entirely sure how this would behave on pages like |
|
I'd remove it altogether, but going back is an option too. |
I agree with removing it altogether, but it seems appropriate to keep it on the “Manage Extensions” page, as it’s quite useful for extensions like UserCSS and UserJS. |
* Change gen.action.cancel to gen.action.reset * Create gen.action.reset using make for all languanges * Add a line in CREDITS.md
ce67405 to
8924891
Compare
|
Yes, but there it should function as cancel/close (same as pressing escape or clicking next to it) rather than reset. :-) |
|
PS You might potentially want to hold off on implementing my suggestions for a little bit since other people might have different ideas, depending on how involved it is. |
|
I am not sure I understand the problem with Cancel. Can you please explain again @Frenzie ? |
That depends which problem you mean.
In short, I consider cancel the correct text and behavior. It's just that the behavior is currently broken. |
Extensions would still be using |
makefor all languangesCloses #3662
Changes proposed in this pull request:
How to test the feature manually:
Pull request checklist:
Additional information can be found in the documentation.