Skip to content

Add namespace on i18n files#7965

Open
aledeg wants to merge 2 commits intoFreshRSS:edgefrom
aledeg:enhance/cli-namespace
Open

Add namespace on i18n files#7965
aledeg wants to merge 2 commits intoFreshRSS:edgefrom
aledeg:enhance/cli-namespace

Conversation

@aledeg
Copy link
Copy Markdown
Member

@aledeg aledeg commented Sep 15, 2025

This includes classes and their tests.
This is to prepare for PSR-4.

See https://www.php-fig.org/psr/psr-4/

Changes proposed in this pull request:

  • add namespace on i18n classes
  • add namespace on i18n test classes

Pull request checklist:

  • clear commit messages
  • code manually tested
  • unit tests written (optional if too hard)
  • documentation updated

Additional information can be found in the documentation.

This includes classes and their tests.
This is to prepare for PSR-4.

See https://www.php-fig.org/psr/psr-4/
@Alkarex Alkarex added this to the 1.28.0 milestone Sep 15, 2025
<?php
declare(strict_types=1);

namespace Cli\I18n;
Copy link
Copy Markdown
Member

@Alkarex Alkarex Nov 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would probably be better to have FreshRSS at top level, no?

@Alkarex
Copy link
Copy Markdown
Member

Alkarex commented Nov 8, 2025

While not opposing, I think it adds a lot of noise (+50 lines that do nothing just for this small section and poorer syntax like \Exception) when used at app level, so I am just not super in a hurry to roll out :-)
It is something else for libraries. So maybe it would be better to start with Minz.

@Alkarex Alkarex modified the milestones: 1.28.0, 1.29.0 Dec 16, 2025
@ColonelMoutarde
Copy link
Copy Markdown
Contributor

ColonelMoutarde commented Dec 22, 2025

While not opposing, I think it adds a lot of noise (+50 lines that do nothing just for this small section and poorer syntax like \Exception) when used at app level, so I am just not super in a hurry to roll out :-) It is something else for libraries. So maybe it would be better to start with Minz.

I love this PR, but the top namespace can be "FreshRss"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants