Skip to content

removed VectorFeatureView and VectorOnlineStore #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
michaelbackes merged 3 commits into from
Aug 17, 2023
Merged

removed VectorFeatureView and VectorOnlineStore #16

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ca9fa0e
removed VectorFeatureView and VectorOnlineStore
Aug 15, 2023
97704b6
removed print statement and moved tag to right location
Aug 16, 2023
8035cf9
adding upper limit for dimensions in Milvus
Aug 16, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
removed print statement and moved tag to right location
  • Loading branch information
mbackes committed Aug 16, 2023
commit 97704b63ef4b1c74f080bad0c7bbb01fce05dbfa
6 changes: 2 additions & 4 deletions sdk/python/tests/integration/feature_repos/universal/feature_views.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -296,22 +296,20 @@ def create_pushable_feature_view(batch_source: DataSource):

def create_vector_feature_view(source):
driver_entity = driver()
vector_tag = {"dimensions": 50}
feature_view_tag = {"index_algorithm": "hnsw"}
vector_tags = {"dimensions": 50, "index_type": "hnsw"}
vector_feature_view = FeatureView(
name="driver_profile",
entities=[driver_entity],
schema=[
Field(
name="profile_embedding",
dtype=Array(base_type=Float32),
tags=vector_tag,
tags=vector_tags,
),
Field(name="lifetime_trip_count", dtype=Int32),
Field(name=driver_entity.join_key, dtype=Int32),
],
source=source,
tags=feature_view_tag,
)

return vector_feature_view
1 change: 0 additions & 1 deletion sdk/python/tests/integration/online_store/test_universal_online.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -572,7 +572,6 @@ def test_write_vectors_to_online_store(environment, universal_data_sources):
driver_daily_stats = create_vector_feature_view(data_sources.customer)
driver_entity = driver()

print("running apply at: " + time.strftime("%H:%M:%S", time.localtime()))
# Register Feature View and Entity
fs.apply([driver_daily_stats, driver_entity])

Expand Down