Skip to content

fix: Parsing online store configuration correctly when provider is ex… #123

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
EXPEbdodla wants to merge 4 commits into
base: master
Choose a base branch
from
Open

fix: Parsing online store configuration correctly when provider is ex… #123

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
47b2a18
fix: Parsing online store configuration correctly when provider is ex…
Aug 2, 2024
7023bee
fix: Fix compatibility issues between Pydantic V1 and V2 with timedelta
Jul 26, 2024
e981b4b
feat: Add ttl parameter to FeatureView and FeatureService constructors
Jul 28, 2024
4548800
feat: Update validate_ttl method to handle optional ttl parameter
Jul 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
fix: Parsing online store configuration correctly when provider is ex… 
…pedia
  • Loading branch information
Bhargav Dodla committed Aug 2, 2024
commit 47b2a1878e25c910490839a5ebf61cdb2e278144
2 changes: 1 addition & 1 deletion sdk/python/feast/repo_config.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -228,7 +228,7 @@ def __init__(self, **data: Any):

self._online_store = None
if provider == "expedia":
self.online_config = "redis"
self.online_config = data.get("online_store", "redis")
else:
self.online_config = data.get("online_store", "sqlite")

Expand Down
29 changes: 29 additions & 0 deletions sdk/python/tests/unit/infra/scaffolding/test_repo_config.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -223,3 +223,32 @@ def test_repo_config_init_expedia_provider():
assert isinstance(c.online_store, RedisOnlineStoreConfig)
assert isinstance(c.batch_engine, SparkMaterializationEngineConfig)
assert isinstance(c.offline_store, SparkOfflineStoreConfig)


def test_repo_config_init_expedia_provider_with_online_store_config():
c = _test_config(
dedent(
"""
project: foo
registry: "registry.db"
provider: expedia
online_store:
type: redis
connection_string: localhost:6380
redis_type: redis_cluster
key_ttl_seconds: 123456
entity_key_serialization_version: 2
"""
),
expect_error=None,
)
assert c.registry_config == "registry.db"
assert c.offline_config["type"] == "spark"
assert c.online_config["type"] == "redis"
assert c.online_config["connection_string"] == "localhost:6380"
assert c.online_config["redis_type"] == "redis_cluster"
assert c.online_config["key_ttl_seconds"] == 123456
assert c.batch_engine_config == "spark.engine"
assert isinstance(c.online_store, RedisOnlineStoreConfig)
assert isinstance(c.batch_engine, SparkMaterializationEngineConfig)
assert isinstance(c.offline_store, SparkOfflineStoreConfig)