Conversation
appel1
commented
Jun 29, 2026
Collaborator
- Enabled and propagated nullable annotations through core reader, factory, and related components.
- Aligned IDataReader behavior: - GetValue / GetValues now surface DBNull.Value for empty/error cells.
- IsDBNull reflects the above contract.
- Typed getters (including GetString) now behave contract-style (throw on DBNull unless caller checks IsDBNull first).
Apply nullable reference annotations and guarded flows across the reader, factory, core formats, and dataset surfaces. Change NullReferenceException to ObjectDisposedException in a few places.
Update GetValue-based expectations and empty-row checks in tests to match DBNull.Value semantics for null/error cells. Make GetString match IDataRecord contract by throwing on DBNull-backed cells, and update tests to assert IsDBNull plus InvalidCastException where appropriate.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.