Fix builtin time format locale#744
Merged
Merged
Conversation
…20 and 21 Extend GetBuiltinNumberFormat(numFmtId, provider) to derive format strings for built-in indices 20 (h:mm) and 21 (h:mm:ss) from the provider's ShortTimePattern and LongTimePattern respectively, consistent with how index 22 already derives its time component. Also update Issue461.xlsx to include cells with numFmtId 20 and 21, and add corresponding tests.
… on 12h locales Indices 20 (h:mm) and 21 (h:mm:ss) are explicitly non-AM/PM formats. On 12h locales like en-US, deriving from ShortTimePattern/LongTimePattern would incorrectly add AM/PM. Fall back to the hardcoded spec string when the derived pattern contains AM/PM or A/P. Verified against Excel: de-DE gives hh:mm/hh:mm:ss, en-US gives h:mm/h:mm:ss.
72fb917 to
00896f9
Compare
This was referenced Jun 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #432