Skip to content

Add a DataTable Configuration for allows fill the empty cells in merged range to fill by left-top cell value#730

Merged
appel1 merged 3 commits into
ExcelDataReader:developfrom
Flithor:develop
Apr 9, 2026
Merged

Add a DataTable Configuration for allows fill the empty cells in merged range to fill by left-top cell value#730
appel1 merged 3 commits into
ExcelDataReader:developfrom
Flithor:develop

Conversation

@Flithor

@Flithor Flithor commented Nov 13, 2025

Copy link
Copy Markdown
Contributor

@andersnm
solve: #729

@Flithor

Flithor commented Nov 13, 2025

Copy link
Copy Markdown
Contributor Author

Opps, I haven't written a test case.
But it's already too late here.
I'm not sure if this fits your plan, but the result met my expectation.

@andersnm

Copy link
Copy Markdown
Collaborator

@Flithor Cool, I'm just a lurker these days but this looks useful to me. It deserves some tests, in particular when dealing with more irregular merged ranges. Suggest to add some tests later when you can, I guess there is no rush

@Flithor

Flithor commented Nov 14, 2025

Copy link
Copy Markdown
Contributor Author

@andersnm added the test cases and fix bug, I think it worth to merge and publish.

Our project management strategy prefers to use NuGet packages directly.

@Flithor

Flithor commented Nov 26, 2025

Copy link
Copy Markdown
Contributor Author

@andersnm I wanted to ask if you could review and merge this pending pull request.
And would it be possible to publish a new release to NuGet? So that the community can benefit from the update.
Thank you.

@andersnm

Copy link
Copy Markdown
Collaborator

@Flithor Apologies, I'm personally unable to review and merge these days, but I'm sure @appel1 will take a look at this at some point.

@appel1

appel1 commented Nov 26, 2025

Copy link
Copy Markdown
Collaborator

Haven't had time. Sorry.

I think it's a good addition but want to look at the code before I merge.

@Flithor

Flithor commented Nov 27, 2025

Copy link
Copy Markdown
Contributor Author

My initial design include three fill mode: horizontal fill, vertical fill, and full fill.

However, I've found that scenarios on read the sheet as a DataTable almost always for reading formatted table data, and the first two fill mode seemed no uses. So, only retain the full fill.

I'm not sure if horizontal and vertical fill have any other uses.

@Flithor

Flithor commented Dec 20, 2025

Copy link
Copy Markdown
Contributor Author

@appel1 Hello? Any progress?

@Flithor

Flithor commented Feb 6, 2026

Copy link
Copy Markdown
Contributor Author

There were long times ago......

@appel1 appel1 merged commit d7bbf95 into ExcelDataReader:develop Apr 9, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants