Skip to content

Read Strict Open XML Excel files #531

Merged
appel1 merged 7 commits into
ExcelDataReader:developfrom
macrobond:issue498
Mar 10, 2023
Merged

Read Strict Open XML Excel files #531
appel1 merged 7 commits into
ExcelDataReader:developfrom
macrobond:issue498

Conversation

@monikalaks

@monikalaks monikalaks commented May 20, 2021

Copy link
Copy Markdown
Contributor

This will fix the problem with reading the Strict Open XML Excel files. Based on #498

@appel1

appel1 commented May 27, 2021

Copy link
Copy Markdown
Collaborator

This PR is for #498, not the other issue.

@SooriyanDSRC

Copy link
Copy Markdown

@andersnm Please let us know when will this feature will be available

@iamherrylok

Copy link
Copy Markdown

@appel1 when will we support to read strict open xml excel files?

@appel1

appel1 commented Nov 16, 2022

Copy link
Copy Markdown
Collaborator

@iamherrylok I don't know. I'm trying to get in contact with the current owner of the repo to get enough access so I can merge PRs and do a new release. No luck so far unfortunately.

@Ian1971

Ian1971 commented Nov 16, 2022

Copy link
Copy Markdown
Collaborator

I'm not the original owner. I did a bunch of work on this a few years ago, but not for a long time. I do seem to have pull access though. I don't seem to have any other rights, likely granting access.

@andersnm

Copy link
Copy Markdown
Collaborator

Hi @Ian1971 !

Can you still log in with the "ExcelDataReader" user? I always assumed it was you who had the credentials for it, surely it was you who granted me access back in the days per this thread? #169

@Ian1971

Ian1971 commented Nov 16, 2022

Copy link
Copy Markdown
Collaborator

hmmm good point. I don't remember having the login for that user but will check

@Ian1971

Ian1971 commented Nov 16, 2022

Copy link
Copy Markdown
Collaborator

Hey I got in. Many apologies for not spotting this sooner. I could transfer the repo to you or arrange to get you the login (so that the repo url remains unchanged)

@andersnm

Copy link
Copy Markdown
Collaborator

@Ian1971 Cool! It would be nice to keep the URL, so we should arrange for somebody else to take over and maybe convert the ExcelDataReader user to a Github organisation. I could do it, but my vote goes to @appel1 who's the most active contributor currently, as myself has been sidelined by personal issues the last years

@Ian1971

Ian1971 commented Nov 16, 2022

Copy link
Copy Markdown
Collaborator

You have nuget access?

@andersnm

Copy link
Copy Markdown
Collaborator

@Ian1971 We're good on Nuget. Tho @appel1 still has a pending invite to join the recently created ExcelDataReader organization (Nuget user "appel")

@appel1

appel1 commented Nov 20, 2022

Copy link
Copy Markdown
Collaborator

@andersnm Weird, never got any notification about that.

@Ian1971

Ian1971 commented Nov 22, 2022

Copy link
Copy Markdown
Collaborator

@appel1 You want me to send you the ExcelDataReader login somehow?

@appel1

appel1 commented Nov 28, 2022

Copy link
Copy Markdown
Collaborator

@Ian1971 Sure, e-mail works for me.

@Ian1971

Ian1971 commented Nov 30, 2022

Copy link
Copy Markdown
Collaborator

What email shall I use?

@appel1

appel1 commented Nov 30, 2022

Copy link
Copy Markdown
Collaborator

Right, sent you an email (I think).

@Ian1971

Ian1971 commented Nov 30, 2022

Copy link
Copy Markdown
Collaborator

Cheers. Replied. Hopefully all good?

@appel1

appel1 commented Nov 30, 2022

Copy link
Copy Markdown
Collaborator

Yes, looks good. Thanks.

@appel1

appel1 commented Dec 1, 2022

Copy link
Copy Markdown
Collaborator

@monikalaks Can you fix the conflicts?

Comment thread src/ExcelDataReader/Core/OpenXmlFormat/XmlFormat/XmlStylesReader.cs Outdated
@appel1 appel1 merged commit 21bf2b7 into ExcelDataReader:develop Mar 10, 2023
@appel1 appel1 deleted the issue498 branch March 10, 2023 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants