Null check for GetCellError()#485
Merged
Merged
Conversation
Collaborator
|
Hi and thanks! Would you mind adding a test to go with this, f.eks add the following in ExcelTestBase.cs: [Test]
public void GitIssue483CellErrorEmptyRow()
{
// Check there are four rows with no errors and no NREs
using (var reader = OpenReader("CollapsedHide"))
{
reader.Read();
Assert.AreEqual(null, reader.GetCellError(0));
Assert.AreEqual(null, reader.GetCellError(1));
reader.Read();
Assert.AreEqual(null, reader.GetCellError(0));
Assert.AreEqual(null, reader.GetCellError(1));
reader.Read();
Assert.AreEqual(null, reader.GetCellError(0));
Assert.AreEqual(null, reader.GetCellError(1));
reader.Read();
Assert.AreEqual(null, reader.GetCellError(0));
Assert.AreEqual(null, reader.GetCellError(1));
}
} |
Collaborator
|
FYI, I believe the error on Appveyor is harmless - apparently the build server image was upgraded since your last commit (MSBuild version 16.6.0+5ff7b0c9e updated to version 16.7.0+b89cb5fde). One of the changes is a Nuget warning I've ignored has become an error |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.