Handle duplicate number format records by using the first one.#455
Merged
Conversation
andersnm
reviewed
Jun 20, 2020
| private void ReadWorkbookGlobals(XlsBiffStream biffStream) | ||
| { | ||
| XlsBiffRecord rec; | ||
| var biffFormats = new Dictionary<ushort, XlsBiffFormatString>(); |
Collaborator
There was a problem hiding this comment.
FYI, the purpose of the temporary biffFormats dict was to make sure the CODEPAGE record is parsed before decoding the format strings. The new code assumes the CODEPAGE record comes before the FORMAT records. It's probably OK as-is by the spec, although I'd be happier if we could revert these changes in XlsWorkbook.cs before merging
…ase there are any format records before the codepage record.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #454