Skip to content

Only use values from cell XF.#439

Merged
andersnm merged 2 commits into
ExcelDataReader:developfrom
appel1:issue438
Nov 16, 2019
Merged

Only use values from cell XF.#439
andersnm merged 2 commits into
ExcelDataReader:developfrom
appel1:issue438

Conversation

@appel1

@appel1 appel1 commented Nov 5, 2019

Copy link
Copy Markdown
Collaborator

Re issue #438.

@andersnm

andersnm commented Nov 7, 2019

Copy link
Copy Markdown
Collaborator

Hi,

I found this PR a bit brutal at first, but upon closer examination and xrefing the MS-XLS "2.5.20 CellXF" spec:

fAtrFnt (1 bit): A bit that specifies that if the ifnt field of the XF record specified by the ixfParent field of the containing XF record is updated, the corresponding field of the containing XF record will not be set to the same value.

That's a mouthful, but sounds like the Cell XF alone is indeed sufficient to determine the cell styles: XLS authoring apps (like Excel) should update the Cell XF per the UsedAttributes flags whenever the parent Cell Style XF changes.

Nice find!

@andersnm andersnm merged commit b640063 into ExcelDataReader:develop Nov 16, 2019
@appel1 appel1 deleted the issue438 branch August 24, 2020 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants