Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: ExcelDataReader/ExcelDataReader
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: develop
Choose a base ref
...
head repository: ExcelDataReader/ExcelDataReader
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: nullable
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 2 commits
  • 69 files changed
  • 1 contributor

Commits on Jun 29, 2026

  1. Enable nullable annotations across reader codebase 

    Apply nullable reference annotations and guarded flows across the reader, factory, core formats, and dataset surfaces.
Change NullReferenceException to ObjectDisposedException in a few places.
    @appel1
    appel1 committed Jun 29, 2026
    Configuration menu
    Copy the full SHA
    60eecb2 View commit details
    Browse the repository at this point in the history

  2. Align reader null cell behavior with IDataReader contract 

    Update GetValue-based expectations and empty-row checks in tests to match DBNull.Value semantics for null/error cells.
Make GetString match IDataRecord contract by throwing on DBNull-backed cells, and update tests to assert IsDBNull plus InvalidCastException where appropriate.
    @appel1
    appel1 committed Jun 29, 2026
    Configuration menu
    Copy the full SHA
    e3755ae View commit details
    Browse the repository at this point in the history
Loading