Skip to content

Find Places Devlab#290

Closed
mpayson wants to merge 45 commits into
Esri:dev_site_currentfrom
mpayson:mp-devlab-find-places
Closed

Find Places Devlab#290
mpayson wants to merge 45 commits into
Esri:dev_site_currentfrom
mpayson:mp-devlab-find-places

Conversation

@mpayson
Copy link
Copy Markdown
Contributor

@mpayson mpayson commented Aug 10, 2018

Solution for a new Python Find Places DevLab. The DevLab preview is available internally here

jyaistMap and others added 30 commits June 19, 2018 10:51
Copy link
Copy Markdown
Contributor

@AtmaMani AtmaMani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mpayson all looks good. Can you change g_map.add_layer() to g_map.draw() and call it after the map loads?

@DavidJVitale
Copy link
Copy Markdown
Contributor

@AtmaMani did you test this with the new widget? Do you want me to run through that?

@AtmaMani
Copy link
Copy Markdown
Contributor

@DavidJVitale Yes, could you check this against the new widget?

@mpayson
Copy link
Copy Markdown
Contributor Author

mpayson commented Aug 16, 2018

thanks Atma, done!

@AtmaMani
Copy link
Copy Markdown
Contributor

@mpayson could you send this PR to dev_site_current instead of master? This will helps us deploy to production via CICD.

@mpayson mpayson changed the base branch from master to dev_site_current August 18, 2018 19:57
@AtmaMani
Copy link
Copy Markdown
Contributor

@mpayson I am working on doing a manual merge of this

@mpayson
Copy link
Copy Markdown
Contributor Author

mpayson commented Aug 22, 2018

closing and switching to #295

@mpayson mpayson closed this Aug 22, 2018
@mpayson mpayson deleted the mp-devlab-find-places branch August 22, 2018 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants