This repository was archived by the owner on Nov 6, 2023. It is now read-only.
Fixed compatibility with breitbandmessung.de#9841
Merged
Merged
Conversation
J0WI
reviewed
May 11, 2017
| --> | ||
| <ruleset name="Breitbandmessung.de"> | ||
|
|
||
| <exclusion pattern="^http://breitbandmessung.de/(?:test|images|api|public)/" /> |
Contributor
There was a problem hiding this comment.
Please remove the non-capturing group.
Contributor
|
Can you explain why this exclusion is required? |
- Exclusion and Test URLs specified more precisely - The URLs are exluded, as they need to establish an unsecured WebSocket Connection which would result in Mixed Active Content on HTTPS
J0WI
reviewed
May 14, 2017
J0WI
left a comment
Contributor
There was a problem hiding this comment.
Please only use tabs to indent lines.
J0WI
suggested changes
May 16, 2017
J0WI
left a comment
Contributor
There was a problem hiding this comment.
Please only use tabs to indent lines.
Contributor
|
Now you replaced every tab with whitespaces |
Contributor
Author
|
Sorry guys, I don't know wth is going on with my editor. Whitespaces should now be replaced with tabs. |
J0WI
approved these changes
May 16, 2017
Contributor
|
Thanks! |
This was referenced Feb 12, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.