Skip to content
This repository was archived by the owner on Nov 6, 2023. It is now read-only.

Convert SSL Observatory to use getBrowserForChannel. - #796

Merged
cooperq merged 5 commits into
EFForg:masterfrom
jsha:getbrowserforchannel
Jan 16, 2015
Merged

Convert SSL Observatory to use getBrowserForChannel.#796
cooperq merged 5 commits into
EFForg:masterfrom
jsha:getbrowserforchannel

Conversation

@jsha

@jsha jsha commented Dec 5, 2014

Copy link
Copy Markdown
Member

Fixes #786

jsha added 2 commits December 5, 2014 15:07
@jsha
Convert SSL Observatory to use getBrowserForChannel.
27b0f73
@jsha
Merge branch 'master' into getbrowserforchannel
930ddb4 
Conflicts:
	https-everywhere-tests/test_profile_skeleton/prefs.js
	src/components/ssl-observatory.js
ghost
ghost reviewed Jan 5, 2015
View reviewed changes
Comment thread src/components/ssl-observatory.js Outdated

@ghost ghost Jan 5, 2015

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line gives browser is null ssl-observatory.js:624
Firefox 34.0.5 linux, https-everywhere latest master (currently this commit is latest: d278a6d )
Seems to happen on browser startup(and restores tabs). I don't know what to make of it.

@jsha jsha Jan 9, 2015

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I fixed the by adding a check for browser being defined.

@jsha

jsha commented Jan 9, 2015

Copy link
Copy Markdown
Member Author

ping @cooperq for review.

@ghost

ghost commented Jan 9, 2015

Copy link
Copy Markdown

tl;dr: works ok for me.

Seems to be working alright for me. I get no warnings(aside from the unrelated deprecated nsIJSON.encode) or errors. Thanks.

As an aside, I want to mention that when observatory.eff.org is blocked (in my case, in /etc/hosts made to point to 127.0.0.3 where there is nothing listening on any port there; for tests) then req.status is 0 , req.responseText is empty and thus this shows on firefox console: SSL Observatory WARN: Cert submission failure 0:.

(note to self) This helped me increase Firefox's WebConsole log level:
https://developer.mozilla.org/en-US/Add-ons/SDK/Tools/console#Setting_the_Logging_Level
Basically, about:config New->String extensions.sdk.console.logLevel set value to all.
However, for https-everywhere logs to show up I had to change extensions.https_everywhere.LogLevel from 5 to 1 to see them all (and the above WebConsole log level changes are not required)

cooperq
cooperq reviewed Jan 12, 2015
View reviewed changes
Comment thread src/components/ssl-observatory.js Outdated

@cooperq cooperq Jan 12, 2015

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: Needs a semicolon

@cooperq

cooperq commented Jan 12, 2015

Copy link
Copy Markdown
Contributor

Has this been tested on firefox mobile yet?

@jsha

jsha commented Jan 13, 2015

Copy link
Copy Markdown
Member Author

Not yet, will do. Thanks for the reminder!

@johnp

johnp commented Jan 15, 2015

Copy link
Copy Markdown
Contributor

Will this get merged for the next dev-version? This is really spamming my Browser-Console....

@jsha

jsha commented Jan 15, 2015

Copy link
Copy Markdown
Member Author

Yep!
On 01/14/2015 04:05 PM, Johannes Pfrang wrote:

Will this get merged for the next dev-version? This is really spamming
my Browser-Console....

—
Reply to this email directly or view it on GitHub
#796 (comment).

@jsha

jsha commented Jan 16, 2015

Copy link
Copy Markdown
Member Author

Ok, tested on Firefox mobile and works well.

cooperq added a commit that referenced this pull request Jan 16, 2015
@cooperq
Merge pull request #796 from jsha/getbrowserforchannel
80d93de 
Convert SSL Observatory to use getBrowserForChannel.
@cooperq
cooperq merged commit 80d93de into EFForg:master Jan 16, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

firefox

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Firefox 37: TypeError: this.HTTPSEverywhere.getWindowForChannel is not a function ssl-observatory.js:819:24

3 participants

@jsha @cooperq @johnp