Skip to content
This repository was archived by the owner on Nov 6, 2023. It is now read-only.

bm.ru#5659

Merged
J0WI merged 4 commits intoEFForg:masterfrom
galeksandrp:bm.ru
Feb 14, 2017
Merged

bm.ru#5659
J0WI merged 4 commits intoEFForg:masterfrom
galeksandrp:bm.ru

Conversation

@galeksandrp
Copy link
Copy Markdown
Contributor

No description provided.

@galeksandrp galeksandrp force-pushed the bm.ru branch 3 times, most recently from 5eea15f to a77234b Compare July 25, 2016 03:12
<target host="anketa.bm.ru" />
<target host="anketa-ipoteka.bm.ru" />
<target host="m.bm.ru" />
<target host="bmmobile.bm.ru" />
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see also:
mobile.bm.ru
partner.bm.ru

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added.

Comment thread src/chrome/content/rules/Bm.ru.xml Outdated
<target host="m.bm.ru" />
<target host="bmmobile.bm.ru" />

<exclusion pattern="^http://(?:www\.)?bm.ru/(?!ru/personal/platezhi-i-perevody/perevody-s-kart/perevody-s-karty-na-karty)" />
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please avoid non-capturing group and document the issue.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

Copy link
Copy Markdown
Contributor Author

@galeksandrp galeksandrp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ERROR src/chrome/content/rules/Bm.ru.xml: No rule or exclusion applies to test URL http://bm.ru/
ERROR src/chrome/content/rules/Bm.ru.xml: No rule or exclusion applies to test URL http://www.bm.ru/

But I don't want any rule or exclusion except <rule from="^http://(www\.)?bm\.ru/ru/personal/platezhi-i-perevody/perevody-s-kart/perevody-s-karty-na-karty/" be associated with <target host="bm.ru" />.

@J0WI
Copy link
Copy Markdown
Contributor

J0WI commented Feb 11, 2017

I think you need to make an exception for them on /$ to make our tests happy.

@galeksandrp
Copy link
Copy Markdown
Contributor Author

Added.

@J0WI J0WI merged commit 102523f into EFForg:master Feb 14, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants