This repository was archived by the owner on Nov 6, 2023. It is now read-only.
Remove match_rule and f attributes. - #3883
Merged
Merged
Conversation
This eliminates "moot" as a special category, and treats all rulesets that have a matching target host but are disabled as "inactive" in the applicable rules list, allowing us to eliminate a chunk of regex work in wouldMatch.
Contributor
|
Good call! Cursory LGTM -- I'll test this more over the ~weekend. @blockoperation had a lot of related changes (#1775) for inspiration at https://github.com/blockoperation/https-everywhere/commits/chromium-memory-usage-v2 |
Contributor
There was a problem hiding this comment.
please rm skin/tick-moot.png
Contributor
|
Ok, just a few outstanding |
Member
Author
|
Fixed the issues you mentioned. Thanks! |
Contributor
|
😆 lingering moots |
semenko
added a commit
that referenced
this pull request
Jan 15, 2016
Remove match_rule and f attributes.
jsha
added a commit
to jsha/https-everywhere
that referenced
this pull request
Jan 20, 2016
This caused a regression: Rules that are active but not taking effect (formerly moot rules) are simply not listed, when my intention was to list them (i.e., match the Chrome behavior). Will roll forward again when I have a fix, but didn't want to leave things in a broken state until then.
jsha
added a commit
to jsha/https-everywhere
that referenced
this pull request
Jan 20, 2016
This caused a regression: Rules that are active but not taking effect (formerly moot rules) are simply not listed, when my intention was to list them (i.e., match the Chrome behavior). Will roll forward again when I have a fix, but didn't want to leave things in a broken state until then. This is a partial revert because the Chrome changes were fine, so I'm leaving them.
semenko
added a commit
that referenced
this pull request
Jan 20, 2016
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
They're no longer used.
cc @semenko for review.