This repository was archived by the owner on Nov 6, 2023. It is now read-only.
load FAQ after install only if requested - #3501
Merged
Merged
Conversation
The first time the browser is started after installing https-everywhere, a notification bar is shown, informing of the fact that some https enforcement is active and pointing to the toolbar button for options. What is bad about that is that when the notification is dismissed, the browser is forced to open https://www.eff.org/https-everywhere/faq This is a privacy breach, as it informs the authors (and user's ISP) that there is a new installation of https-everywhere. This change adds a dedicated button to the notification bar. Pressing that button loads the FAQ page as before, and just dismissing the notification bar does nothing. In other words, it makes the user *request* the FAQ before loading it. Fixes #769.
Contributor
|
LGTM -- can someone in the FF code take a look? |
jsha
added a commit
that referenced
this pull request
Jan 30, 2016
load FAQ after install only if requested
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The first time the browser is started after installing
https-everywhere, a notification bar is shown, informing of
the fact that some https enforcement is active and pointing to the
toolbar button for options.
What is bad about that is that when the notification is dismissed, the
browser is forced to open https://www.eff.org/https-everywhere/faq
This is a privacy breach, as it informs the authors (and user's ISP)
that there is a new installation of https-everywhere.
This change adds a dedicated button to the notification bar.
Pressing that button loads the FAQ page as before, and just dismissing
the notification bar does nothing. In other words, it makes the user
request the FAQ before loading it.
Fixes #769.