This repository was archived by the owner on Nov 6, 2023. It is now read-only.
Conversation
To get an automated signature from AMO for self-hosting, we need to have a separate unlisted version of our extension. Because of a problem in AMO, the unlisted version cannot have the same id as the listed version. So we're renaming the self-hosted version to https-everywhere-eff@eff.org. This also includes a change to make-sqlite.py to remove the git commit table. The new release process will require an initial build, then a signature, then a second build. Since that second build will be at a different git commit, rulesets.sqlite would change and cause the signature to no longer match.
cooperq
added a commit
that referenced
this pull request
Aug 18, 2015
Change id of extension for AMO signing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To get an automated signature from AMO for self-hosting, we need to have
a separate unlisted version of our extension. Because of a problem in AMO,
the unlisted version cannot have the same id as the listed version. So we're
renaming the self-hosted version to https-everywhere-eff@eff.org.
This also includes a change to make-sqlite.py to remove the git commit table.
The new release process will require an initial build, then a signature, then a
second build. Since that second build will be at a different git commit,
rulesets.sqlite would change and cause the signature to no longer match.
@cooperq for review.