This repository was archived by the owner on Nov 6, 2023. It is now read-only.
Merged
Conversation
reedy
added a commit
that referenced
this pull request
Aug 16, 2015
[Alphabet] Remove duplicate rule
Contributor
|
@fuglede I don't really care but I just want to let you know that my rule (the one you deleted) was merged on Aug 12 while the one kept was authored on the 15th. 😉 |
Contributor
Author
|
@tonyztan: Ah, thanks for the heads-up. I took the other one partly because it had a bit more info, but primarily because I think it's a lot easier to find rulesets if their file names and target hosts correlate. (Yours might prove more foresightful when Alphabet starts taking over the internet though.) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There are duplicate rules for abc.xyz and www.abc.xyz in the current master, causing ruleset validation to fail. This removes one of those rulesets containing these.