This repository was archived by the owner on Nov 6, 2023. It is now read-only.
Remove in-browser ruleset tests. - #2516
Merged
Merged
Conversation
These were implemented over two years ago, when Firefox first turned on mixed content blocking. They're no longer practical to run because they are so slow and there are too many rulesets. We will probably want to consult this code in the future to create a similar test suite that can run headless on multiple Firefoxes in response to requests from the https-everywhere-checker.
Contributor
|
lgtm |
cooperq
added a commit
that referenced
this pull request
Aug 12, 2015
Remove in-browser ruleset tests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These were implemented over two years ago, when Firefox first turned on mixed
content blocking. They're no longer practical to run because they are so slow
and there are too many rulesets. We will probably want to consult this code in
the future to create a similar test suite that can run headless on multiple
Firefoxes in response to requests from the https-everywhere-checker.
cc @cooperq for review