This repository was archived by the owner on Nov 6, 2023. It is now read-only.
Update Redmine.org.xml - #18807
Merged
Merged
Conversation
Bisaloo
reviewed
Jan 29, 2020
Bisaloo
left a comment
Collaborator
There was a problem hiding this comment.
Could you also trivialize the cookie rule while you're at it please?
pipboy96
approved these changes
Jan 29, 2020
Contributor
Author
Done |
pipboy96
suggested changes
Jan 29, 2020
| @@ -17,23 +10,20 @@ | |||
| - www.redmine.org | |||
|
|
|||
| --> | |||
Contributor
There was a problem hiding this comment.
IMO this comment and the next one is unnecessary, since there is no reason to list nonexistent domains and domains which set insecure cookies.
Bisaloo
approved these changes
Feb 2, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.