Skip to content
This repository was archived by the owner on Nov 6, 2023. It is now read-only.

Changes corresponding to the changes in the lib-wasm submodule - #18117

Merged
Hainish merged 3 commits into
EFForg:masterfrom
Hainish:wasm
Jun 26, 2019
Merged

Changes corresponding to the changes in the lib-wasm submodule#18117
Hainish merged 3 commits into
EFForg:masterfrom
Hainish:wasm

Conversation

@Hainish

@Hainish Hainish commented Jun 22, 2019

Copy link
Copy Markdown
Member

No description provided.

@Hainish Hainish added the wasm label Jun 22, 2019
@Hainish Hainish changed the title Changes corresponding to the changes in the lib-wasm submodule [WIP] Changes corresponding to the changes in the lib-wasm submodule Jun 22, 2019
@pipboy96

Copy link
Copy Markdown
Contributor

Is this just renaming the library?

@Hainish

Hainish commented Jun 24, 2019

Copy link
Copy Markdown
Member Author

@pipboy96 this separates the WASM library from a new generalized core library which is abstracted from any WASM specifics.

Please go ahead and do git submodule update --init --recursive and re-build the docker container and build the .wasm file again to verify.

@Hainish Hainish changed the title [WIP] Changes corresponding to the changes in the lib-wasm submodule Changes corresponding to the changes in the lib-wasm submodule Jun 24, 2019
@Hainish

Hainish commented Jun 25, 2019

Copy link
Copy Markdown
Member Author

@pipboy96 feel free to re-check whenever you have a chance. I'd like to include a test in the https://github.com/EFForg/https-everywhere-lib-wasm repo which checks if the build hash is the same as expected. I've assigned this to myself: EFForg/https-everywhere-lib-wasm#2

@pipboy96

Copy link
Copy Markdown
Contributor

@Hainish I can right now, sry for delay.

@pipboy96

pipboy96 commented Jun 26, 2019

Copy link
Copy Markdown
Contributor

@Hainish

✅ Successfully reproduced!

🔒 GPG-signed statement
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

I, pipboy96 (pipboy96@protonmail.com), hereby testify that a file called https_everywhere_lib_bg.wasm with SHA-256 hash of 73b09852436067ad1f13357d4c2d0dff9a3d9c7ac0932e7396ed3499483d677d and size of 93394 bytes fully corresponds to a Git commit with hash a616064ac86244c522a8088086d8821987f29fd6 and was successfully reproduced by me from its source code.
-----BEGIN PGP SIGNATURE-----

iI4EARYIADYWIQROV8sHuKtZUjpKQXlrXPDIQKF3dAUCXRK7PxgccGlwYm95OTZA
cHJvdG9ubWFpbC5jb20ACgkQa1zwyEChd3Q4ggEA1jblFMejyd2PwVWAv6M/Uvju
Y3qDweQvAwJGHMMh9H8A/3pAvxrK2alw/tdZIvIWARBEtkehg4ghw9xNP7sQUFAL
=bIBn
-----END PGP SIGNATURE-----

EDIT: the file name in the signed statement has a mistake, it's supposed to be https_everywhere_lib_wasm_bg.wasm. Both hashes and the file size are correct.

@Hainish
Hainish merged commit c9ef135 into EFForg:master Jun 26, 2019
@Hainish
Hainish deleted the wasm branch June 26, 2019 22:26
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants