Skip to content
This repository was archived by the owner on Nov 6, 2023. It is now read-only.

Minor style fixes to cschanaj script - #18063

Merged
Hainish merged 6 commits into
EFForg:masterfrom
pipboy96:minor-style-fixes
Jun 6, 2019
Merged

Minor style fixes to cschanaj script#18063
Hainish merged 6 commits into
EFForg:masterfrom
pipboy96:minor-style-fixes

Conversation

@pipboy96

@pipboy96 pipboy96 commented Jun 6, 2019

Copy link
Copy Markdown
Contributor

Feel free to partially merge/cherrypick if needed.

@pipboy96
pipboy96 requested review from Hainish and cschanaj June 6, 2019 17:02
@Hainish
Hainish merged commit ed9edec into EFForg:master Jun 6, 2019
@Hainish

Hainish commented Jun 6, 2019

Copy link
Copy Markdown
Member

Looks good and confirmed it still performs as intended

@pipboy96
pipboy96 deleted the minor-style-fixes branch June 6, 2019 17:21
@pipboy96

pipboy96 commented Jun 6, 2019

Copy link
Copy Markdown
Contributor Author

@Hainish can you also do s/new Array()/[]/? I accidentally missed it.

@Hainish

Hainish commented Jun 6, 2019

Copy link
Copy Markdown
Member

@pipboy96 I don't think it necessary to change all instances of this since this is only performed by admins and only once in a while, the performance gains will be minimal. new Array() is still valid even if it is slightly optimized.

@pipboy96

pipboy96 commented Jun 6, 2019

Copy link
Copy Markdown
Contributor Author

@Hainish should #18065 be closed or can you still merge, even though it's not really 100% necessary?

@Hainish

Hainish commented Jun 6, 2019

Copy link
Copy Markdown
Member

Merged.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants