Skip to content
This repository was archived by the owner on Nov 6, 2023. It is now read-only.

Get rid of --privileged in Docker command line - #17376

Merged
Hainish merged 9 commits into
EFForg:masterfrom
pipboy96:patch-40
Feb 26, 2019
Merged

Get rid of --privileged in Docker command line#17376
Hainish merged 9 commits into
EFForg:masterfrom
pipboy96:patch-40

Conversation

@pipboy96

@pipboy96 pipboy96 commented Feb 4, 2019

Copy link
Copy Markdown
Contributor

No description provided.

@pipboy96 pipboy96 changed the title don't merge Get rid of --privileged in Docker command line Feb 4, 2019
@zoracon
zoracon requested a review from Hainish February 22, 2019 01:43
@zoracon

zoracon commented Feb 22, 2019

Copy link
Copy Markdown
Contributor

@pipboy96 Could you give a brief explanation on why this change is beneficial?

Pinging @Hainish here since the ipv6 implementation was done by him initially

@pipboy96

pipboy96 commented Feb 22, 2019

Copy link
Copy Markdown
Contributor Author

@zoracon Generally, --privileged disables most of Docker's security features.

@Hainish

Hainish commented Feb 26, 2019

Copy link
Copy Markdown
Member

lgtm

@Hainish
Hainish merged commit 895dca2 into EFForg:master Feb 26, 2019
@pipboy96
pipboy96 deleted the patch-40 branch February 26, 2019 21:23
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@Hainish Hainish Awaiting requested review from Hainish

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@pipboy96 @zoracon @Hainish