Repository navigation
Update TI.com ruleset - #16701
Update TI.com ruleset#16701
Conversation
J0WI
left a comment
There was a problem hiding this comment.
You removed many comments and targets from Texas-Instruments.xml that are still in use. Please keep them around.
|
Since the rule is currently disabled by default and most of the comments are severely outdated I wanted to bring it to a functional state. These are the subdomains currently (i.e. not this PR) listed in Nonfunctional domains:
Problematic subdomains:
Partially covered subdomains:
Fully covered domains:
Insecure cookies are set for these hosts: Subdomains in targets:
And a few more already mentioned above. TLDR: Almost all comments are outdated, (at least partially) wrong or incomplete, and should not be present in their current state. Of course it would be good to add comments describing the current state, I would argue a link to this issue would suffice for the time being. I'd say that was quite extensive for a rule called "TI.com (partial)" 😄 I'll happily add a few more targets (after additional testing) for
, however I'd first like some feedback. If it makes sense to add subdomains that only redirect as well (if they have valid HTTPS), I can add them too. Targets that I can't verify as working (be it due to errors or potential geoblocking) would have to be contributed by someone else. |
|
Thanks for researching them! We document nonfunctional/problematic in the ruleset file itself: Subdomains that only redirect should also be added as target: Targets that work neither with HTTP nor HTTPS can be removed. |
|
Could someone take a look at this?
If I'm reading it right it says that the URLs don't work (timeout). Even though some of them redirect, they work fine for me with HTTPS. Not sure what the issue is here, especially since www.ti.com worked in the CI test earlier. |
|
They are hosted by Akamai and at times they are blocking our tests. You can add an exclusion here: |
|
Had some issues, but everything looks fine now |
J0WI
left a comment
There was a problem hiding this comment.
Please add a target for estore.ti.com and a comment for m.ti.com (mixed content issues).
|
|
||
|
|
||
| <rule from="^http://ti\.com/" | ||
| to="https://www.ti.com/" /> |
There was a problem hiding this comment.
Please keep this rule and add ti.com as target (but keep the comment about the timeout).
J0WI
left a comment
There was a problem hiding this comment.
I just found a redirect loop, so this needs an exclusion on and test for it:
<exclusion pattern="^http://www\.ti\.com/corp/" />
Also a <exclusion pattern="^http://focus\.ti\.com/$" /> (and test url) is required here, because it behaves differently on HTTP and HTTPS.
|
I'll remove focus.ti.com as a target and move it to the comments, since the issue is not limited to the main page (see http://focus.ti.com/general/docs/traininghome.tsp vs https://focus.ti.com/general/docs/traininghome.tsp) |
|
If there's anything else, let me know |
Update for the disabled Texas Instruments ruleset
Closes #16639