Skip to content
This repository was archived by the owner on Nov 6, 2023. It is now read-only.

Update TI.com ruleset - #16701

Merged
J0WI merged 7 commits into
EFForg:masterfrom
lgoenner:master
Jan 22, 2019
Merged

J0WI merged 7 commits into
EFForg:masterfrom
lgoenner:master

Conversation

@lgoenner

@lgoenner lgoenner commented Oct 8, 2018

Copy link
Copy Markdown
Contributor

Update for the disabled Texas Instruments ruleset

  • Datasheets (example) and tools (example) can be viewed normally via HTTPS, so no exclusion should be necessary
  • Most of the subdomains covered in the old ruleset simply redirect to www.ti.com or are no longer use
  • Access via Tor Browser seems to be blocked

Closes #16639

@Hainish Hainish added the top-10k label Oct 8, 2018

@J0WI J0WI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You removed many comments and targets from Texas-Instruments.xml that are still in use. Please keep them around.

@lgoenner

lgoenner commented Jan 4, 2019

Copy link
Copy Markdown
Contributor Author

Since the rule is currently disabled by default and most of the comments are severely outdated I wanted to bring it to a functional state.

These are the subdomains currently (i.e. not this PR) listed in Texas-Instruments.xml with the behaviour observed today:

Nonfunctional domains:

Subdomain Behaviour
careers HTTPS supported, target contained in PR
education HTTPS supported
m HTTPS supported with mixed content (should be covered by the www.ti.com target)
investor HTTPS supported
newscenter Redirects to news, for which HTTP already redirects to HTTPS
reviews Redirects to www.ti.com
processors.wiki 503, correctly stated in current version
www2 timeout using both HTTP and HTTPS

Problematic subdomains:

Subdomain Behaviour
^ (ti.com) HTTP redirects to www, HTTPS times out
e2e-uat HTTPS supported
www-k.ext HTTP redirects to specific page, invalid HTTPS cert
trainingcenter Redirects (via focus.ti.com) to training (for which HTTP already redirects to HTTPS), HTTPS times out
videos Redirects (via www.ti.com) to training, HTTPS times out
www comment mentions tor users being blocked (which is correct), but there are no tor specific rules in this PR

Partially covered subdomains:

Subdomain Behaviour
www-k.ext see Problematic subdomains
www as described in the PR, the issues mentioned don't occur anymore

Fully covered domains:
DNS entries for www.national.com point to buy.ti.com, which times out for me (might work in the US?). national.com times out for me too. However https://www.ti.com still tries to load content from national.com and national.com.ti.com (no DNS entries, probably a path error).

Subdomain Behaviour
e2e HTTPS supported, target contained in PR
e2e-uat see Problematic subdomains
fedid.ext redirects to www.ti.com, HTTPS supported

Insecure cookies are set for these hosts:
The current version only lists e2e.ti.com. It seems like cookies with Secure: False are set for more hosts, including .ti.com and www.ti.com.

Subdomains in targets:

Subdomain Behaviour
commerce HTTP takes quite a long time and results in a 504, same for HTTPS (although with valid cert)
focus HTTPS supported
my redirects to myportal
myportal HTTPS supported

And a few more already mentioned above.

TLDR: Almost all comments are outdated, (at least partially) wrong or incomplete, and should not be present in their current state. Of course it would be good to add comments describing the current state, I would argue a link to this issue would suffice for the time being.

I'd say that was quite extensive for a rule called "TI.com (partial)" 😄

I'll happily add a few more targets (after additional testing) for

  • e2e-uat
  • training
  • focus
  • myportal

, however I'd first like some feedback.

If it makes sense to add subdomains that only redirect as well (if they have valid HTTPS), I can add them too. Targets that I can't verify as working (be it due to errors or potential geoblocking) would have to be contributed by someone else.

@J0WI

J0WI commented Jan 4, 2019

Copy link
Copy Markdown
Contributor

Thanks for researching them!

We document nonfunctional/problematic in the ruleset file itself:
https://github.com/EFForg/https-everywhere/blob/master/CONTRIBUTING.md#non-working-hosts

Subdomains that only redirect should also be added as target:
https://www.eff.org/https-everywhere/faq#why-does-https-everywhere-include-rules-for-sites-like-paypal-that-already-require-https-on-all-their-pages

Targets that work neither with HTTP nor HTTPS can be removed.

@lgoenner lgoenner closed this Jan 21, 2019
@lgoenner lgoenner reopened this Jan 21, 2019
@lgoenner

Copy link
Copy Markdown
Contributor Author

Could someone take a look at this?

ERROR src/chrome/content/rules/Texas-Instruments.xml: Fetch error: http://www.ti.com/ => https://www.ti.com/: (28, 'Operation timed out after 30001 milliseconds with 0 bytes received') ERROR src/chrome/content/rules/Texas-Instruments.xml: Fetch error: http://focus.ti.com/ => https://focus.ti.com/: (28, 'Operation timed out after 30001 milliseconds with 0 bytes received') ERROR src/chrome/content/rules/Texas-Instruments.xml: Fetch error: http://fedid.ext.ti.com/ => https://fedid.ext.ti.com/: (28, 'Operation timed out after 30001 milliseconds with 0 bytes received') ERROR src/chrome/content/rules/Texas-Instruments.xml: Fetch error: http://investor.ti.com/ => https://investor.ti.com/: (28, 'Operation timed out after 30001 milliseconds with 0 bytes received')

If I'm reading it right it says that the URLs

don't work (timeout). Even though some of them redirect, they work fine for me with HTTPS. Not sure what the issue is here, especially since www.ti.com worked in the CI test earlier.

@J0WI

J0WI commented Jan 21, 2019

Copy link
Copy Markdown
Contributor

They are hosted by Akamai and at times they are blocking our tests. You can add an exclusion here:
https://github.com/EFForg/https-everywhere/blob/master/utils/ruleset-whitelist.csv

@lgoenner

Copy link
Copy Markdown
Contributor Author

Had some issues, but everything looks fine now

@J0WI J0WI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a target for estore.ti.com and a comment for m.ti.com (mixed content issues).



<rule from="^http://ti\.com/"
to="https://www.ti.com/" />

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please keep this rule and add ti.com as target (but keep the comment about the timeout).

@J0WI J0WI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just found a redirect loop, so this needs an exclusion on and test for it:
<exclusion pattern="^http://www\.ti\.com/corp/" />
Also a <exclusion pattern="^http://focus\.ti\.com/$" /> (and test url) is required here, because it behaves differently on HTTP and HTTPS.

@lgoenner

Copy link
Copy Markdown
Contributor Author

I'll remove focus.ti.com as a target and move it to the comments, since the issue is not limited to the main page (see http://focus.ti.com/general/docs/traininghome.tsp vs https://focus.ti.com/general/docs/traininghome.tsp)

@lgoenner

Copy link
Copy Markdown
Contributor Author

If there's anything else, let me know

@J0WI J0WI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@J0WI
J0WI merged commit be57e02 into EFForg:master Jan 22, 2019
@J0WI J0WI mentioned this pull request Jan 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants