This repository was archived by the owner on Nov 6, 2023. It is now read-only.
Documenting ruleset update channels - #16446
Merged
Merged
Conversation
Hainish
force-pushed
the
docs-ruleset-update-channels
branch
from
August 31, 2018 23:31
c755ece to
13d4229
Compare
Member
Author
cschanaj
reviewed
Sep 1, 2018
| Next, | ||
|
|
||
| cd https-everywhere | ||
| rm rules/*.xml |
Collaborator
There was a problem hiding this comment.
One can save the time rm the existing rulesets by pointing utils/merge-rulesets.py to the correct directory.
https-everywhere/utils/merge-rulesets.py
Lines 25 to 27 in b87b31b
Member
Author
There was a problem hiding this comment.
I want to avoid the possibility that a ruleset channel maintainer might forget this --source_dir flag in the future, and I don't see any harm in simply removing the xml files in rules for anyone maintaining a non-EFF ruleset channel. I'm inclined to keep it, since adding a mkdir and pointing to it using --source_dir seems about as complicated as what we currently have here.
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.