This repository was archived by the owner on Nov 6, 2023. It is now read-only.
Increase selenium query_selector timeout - #15396
Merged
Merged
Conversation
Collaborator
|
@Hainish, can you have a look at this? It's almost impossible to merge any PR because the tests are failing way too often. |
Member
|
Hey @bcyphers can you look at this? Thanks. |
Contributor
Collaborator
Author
Contributor
|
Ah ok. I still think this is fine to merge, but it might help more to add some retries on failure for parts of the code that seem to break a lot. We have had similar issues with Privacy Badger; see e.g. EFForg/privacybadger#1894 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.