Skip to content
This repository was archived by the owner on Nov 6, 2023. It is now read-only.

Add ruleset: nvmexpress.org - #15128

Merged
Bisaloo merged 4 commits into
EFForg:masterfrom
injust:patch-1
Apr 16, 2018
Merged

Add ruleset: nvmexpress.org#15128
Bisaloo merged 4 commits into
EFForg:masterfrom
injust:patch-1

Conversation

@injust

@injust injust commented Apr 10, 2018

Copy link
Copy Markdown
Contributor

No description provided.

- www.nvmexpress.org
-->

<ruleset name="nvmexpress.org">

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please change the ruleset name to NVMExpress.org

@Bisaloo Bisaloo self-assigned this Apr 16, 2018
@Bisaloo

Bisaloo commented Apr 16, 2018

Copy link
Copy Markdown
Collaborator

Please change the filename to NVMExpress.org.xml

@@ -0,0 +1,11 @@
<!--
Invalid certificate:
- www.nvmexpress.org

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's okay to add it as a target with a special rule:

	<rule from="^http://www\.nvmexpress\.org/"
		to="https://nvmexpress.org" />

@Bisaloo

Bisaloo commented Apr 16, 2018

Copy link
Copy Markdown
Collaborator

My bad, I forgot the trailing slash

	<rule from="^http://www\.nvmexpress\.org/"
		to="https://nvmexpress.org/" />

Sorry about that!

@Bisaloo Bisaloo closed this Apr 16, 2018
@Bisaloo Bisaloo reopened this Apr 16, 2018
@injust injust closed this Apr 16, 2018
@injust injust reopened this Apr 16, 2018
@Bisaloo
Bisaloo merged commit d51982f into EFForg:master Apr 16, 2018
Bisaloo pushed a commit that referenced this pull request Apr 19, 2018
@Bisaloo Bisaloo removed their assignment May 12, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants