Skip to content
This repository was archived by the owner on Nov 6, 2023. It is now read-only.

Add section about ghost pull requests. - #14580

Closed
ghost wants to merge 1 commit into
masterfrom
unknown repository
Closed

Add section about ghost pull requests.#14580
ghost wants to merge 1 commit into
masterfrom
unknown repository

Conversation

@ghost

@ghost ghost commented Feb 10, 2018

Copy link
Copy Markdown

Fixes #13887.

@Hainish

Hainish commented Feb 14, 2018

Copy link
Copy Markdown
Member

@sampablokuper my text in #13887 (comment) was pretty carefully crafted. Any reason for the change here?

@ghost

ghost commented Feb 14, 2018

Copy link
Copy Markdown
Author

@Hainish, yes. Your text is good, but:

  • Your text implicitly raised, yet did not explicitly answer, the question, "Don't maintainers reserve the right to close PRs without any comment, regardless?"
  • The first sentence of your second paragraph seemed superfluous. Having already explained, by that point, what @ghost PRs are and how they arise, you do not need to also tell readers how to avoid creating them, because it is implicit in what you have already said.

My wording attempts to address those points, and also to be more concise. Running wc on our respective texts gives:

$ wc hainish.md
  3 102 775 hainish.md
$ wc spk.md
  1  52 429 spk.md

i.e. a ~49% reduction in words and a ~45% reduction in characters.

If you still prefer your wording, I am happy to modify this PR accordingly 🙂

@Hainish

Hainish commented Feb 15, 2018

Copy link
Copy Markdown
Member

@sampablokuper I do prefer my wording, making specific why it is inconvenient for maintainers. I've committed this in 376c84a. Thanks for this though!

@Hainish Hainish closed this Feb 15, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant