Skip to content
This repository was archived by the owner on Nov 6, 2023. It is now read-only.

Clean up test execution flow - #14570

Merged
Hainish merged 6 commits into
EFForg:masterfrom
Hainish:test-cleanup
Feb 9, 2018
Merged

Clean up test execution flow#14570
Hainish merged 6 commits into
EFForg:masterfrom
Hainish:test-cleanup

Conversation

@Hainish

@Hainish Hainish commented Feb 8, 2018

Copy link
Copy Markdown
Member

No description provided.

@Hainish

Hainish commented Feb 9, 2018

Copy link
Copy Markdown
Member Author

cc @jeremyn @J0WI @Bisaloo @cschanaj Just an FYI: I've cleaned up the tests here. Mainly, I've renamed the rules test to the validations test, and separated out test/validations.sh so that the validations test in test/run_travis.sh just calls out to that. It is now called from test.sh, so contributors will be running all the validations and not just the test coverage validation when they run ./test.sh.

I've also moved much of the testing infrastructure into tests/ and created a tests/validations/ path, where all the validation tests live. These were previously under utils/ which I thought was inappropriate since they're used mainly for tests. utils/ I consider something that, when run, creates commitable output. This is why I've retained remove-obsolete-references.sh in utils/ - it serves both purposes, but it can be run separate from the testing infrastructure.

@Hainish
Hainish merged commit b49b032 into EFForg:master Feb 9, 2018
@jeremyn

jeremyn commented Feb 9, 2018

Copy link
Copy Markdown
Contributor

FYI to anyone wondering: fetch-test.sh is now test/manual.sh. So instead of:

$ ./fetch-test.sh rules/Freerangekitten.com.xml

You can run:

$ test/manual.sh rules/Freerangekitten.com.xml

fetch-test.sh is still mentioned at docs/en_US/development.md#testing-and-contributing-changes-to-the-source-code.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants