Skip to content
This repository was archived by the owner on Nov 6, 2023. It is now read-only.

[PressLabs.com] Simplify and rename ruleset - #14194

Merged
jeremyn merged 4 commits into
EFForg:masterfrom
Bisaloo:oresslabs
Jan 23, 2018
Merged

[PressLabs.com] Simplify and rename ruleset#14194
jeremyn merged 4 commits into
EFForg:masterfrom
Bisaloo:oresslabs

Conversation

@Bisaloo

@Bisaloo Bisaloo commented Jan 5, 2018

Copy link
Copy Markdown
Collaborator

No description provided.

@jeremyn

jeremyn commented Jan 19, 2018

Copy link
Copy Markdown
Contributor

Add target

Also:

@jeremyn jeremyn self-assigned this Jan 19, 2018
@Bisaloo

Bisaloo commented Jan 21, 2018

Copy link
Copy Markdown
Collaborator Author

Can we keep the test url for cdn.presslabs.com? I like having additional test urls when $ doesn't return the same HTTP code than the other paths of the subdomain.

@jeremyn

jeremyn commented Jan 21, 2018

Copy link
Copy Markdown
Contributor

Looking at just this ruleset, I understand why you want the test. The point of cdn is probably to serve static assets, and the redirect behavior for the root URL is atypical.

The problem I have is that, for me -- maybe some of the other maintainers disagree -- I don't like the idea of optional extra tests. Each test should be there for some specific reason, and in any situation either a test is required to be there or to be absent. So going forward I would either need to ask other contributors to add these tests, or else remember that you personally have a particular preference, and I don't really like either option.

Anyway what we are really testing in most cases is whether there is HTTPS misconfiguration at the server, which any 2XX/3XX response rules out.

@jeremyn

jeremyn commented Jan 22, 2018

Copy link
Copy Markdown
Contributor

I merged PR #14359 which has a similar situation as the one here, an extra test for an img subdomain. We can go ahead and merge this one if you want as it is, just let me know. Still, I would like to keep the number of tests down.

@Bisaloo

Bisaloo commented Jan 22, 2018

Copy link
Copy Markdown
Collaborator Author

Still, I would like to keep the number of tests down.

I will try to keep that in mind. I would be great if you can merge it as it is.

@jeremyn

jeremyn commented Jan 22, 2018

Copy link
Copy Markdown
Contributor

We should also update the filename reference in PressLabs_SSL.xml. I've added a new item to the checklist. I'm sorry to add this at the last minute.

@jeremyn jeremyn mentioned this pull request Jan 23, 2018
@jeremyn
jeremyn merged commit 7e851e2 into EFForg:master Jan 23, 2018
@jeremyn

jeremyn commented Jan 23, 2018

Copy link
Copy Markdown
Contributor

Thanks, merged.

@jeremyn jeremyn removed their assignment Jan 23, 2018
@Bisaloo
Bisaloo deleted the oresslabs branch January 23, 2018 21:19
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants