This repository was archived by the owner on Nov 6, 2023. It is now read-only.
Conversation
* Re-run Travis * Update MIT.xml * Update MIT.xml * Update MIT.xml * Update MIT.xml * Update MIT.xml * Update MIT-mismatches.xml * Update MIT.xml * Update MIT.xml * Update MIT-mismatches.xml * Update MIT.xml * Update MIT.xml * Update MIT.xml * Update MIT.xml * Update MIT.xml
Contributor
|
@J0WI For what it's worth, I don't agree with how you handled this. As I wrote in #12002 (comment), I think you should have resubmitted the old PR with your extra changes as a new PR and then waited for someone else to review it. Instead you effectively self-committed many changes to a complicated I'm not accusing you of anything or whatever, but I think we should discuss this as a group first if you plan on taking this approach to future abandoned / @ghost PRs. |
|
Could this PR be causing #14397? |
Contributor
|
I've added a comment at #14397 (comment). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.