Skip to content
This repository was archived by the owner on Nov 6, 2023. It is now read-only.

SQLite followup: Remove target tags from stored XML, saving 100kB from .xpi - #128

Merged
diracdeltas merged 5 commits into
EFForg:masterfrom
jsha:smaller_target
Feb 5, 2014
Merged

diracdeltas merged 5 commits into
EFForg:masterfrom
jsha:smaller_target

Conversation

@jsha

@jsha jsha commented Jan 29, 2014

Copy link
Copy Markdown
Member

This changes several things:

  • Fixes `view source XML', which my sqlite branch broke.
  • Removes target tags from XML in DB to save space.
  • Changes targets map in HTTPSRules to contain lists of ruleset ids from DB.
  • Deleted code for reading a full directory of rules, which is no longer called anywhere.

@diracdeltas

Copy link
Copy Markdown
Contributor

cool! Somewhat unrelatedly, I merged the sqlite commits (prior to this pull req.) into the Fennec branch and HTTPS Everywhere rewrites stopped happening. Haven't figured out why.

diracdeltas added a commit that referenced this pull request Feb 5, 2014
SQLite followup: Remove target tags from stored XML, saving 100kB from .xpi
@diracdeltas
diracdeltas merged commit c01b491 into EFForg:master Feb 5, 2014
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants