linting and setup fixes - #1
Merged
Merged
Conversation
maapxa
changed the base branch from
fix-for-protobuf-3.11
to
python3.7-compatibility
August 12, 2021 09:59
|
this is awesome, thank you @tmwoodruff we fixed the access issues and can merge this into our p3.7+ branch 🙌 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes issues I ran into running tests (via
make all) using Python 3.8.5.After these changes (+ some riak config, see below), all but three integration tests that run by default are succeeding. The failing tests are
riak.tests.test_mapreduceandriak.tests.test_yokozuna: Error isUnknown message code: 56. Looks like this may be because yokozuna uses Solr, which I haven't configured.test_store_binary_object_from_file_should_use_default_mimetype (riak.tests.test_kv.KVFileTests): Guessing this may just be a difference in how different versions of Riak set MIME types. The MIME type is being set totext/markdownbased on the file extension, but the test is expectingapplication/octet-stream.Some notes on how I installed and configured Riak locally (Ubuntu 20.04) (very likely I've missed some steps here because there was a lot of trial and error):