Widgets: Include widget_text class name on Custom HTML widget wrapper for theme styling compatibility, in addition to previously-added textwidget class on nested content container.

westonruter · westonruter · commit 36c2f88a60c9 · 2017-07-21T21:01:45.000Z
Amends [40893], [41115]. See #40907. Fixes #41392 for trunk. git-svn-id: https://develop.svn.wordpress.org/trunk@41116 602fd350-edb4-49c9-b593-d223f7449a82
diff --git a/src/wp-includes/widgets/class-wp-widget-custom-html.php b/src/wp-includes/widgets/class-wp-widget-custom-html.php
@@ -75,6 +75,9 @@ public function widget( $args, $instance ) {
 		 */
 		$content = apply_filters( 'widget_custom_html_content', $content, $instance, $this );
 
+		// Inject the Text widget's container class name alongside this widget's class name for theme styling compatibility.
+		$args['before_widget'] = preg_replace( '/(?<=\sclass=["\'])/', 'widget_text ', $args['before_widget'] );
+
 		echo $args['before_widget'];
 		if ( ! empty( $title ) ) {
 			echo $args['before_title'] . $title . $args['after_title'];
diff --git a/tests/phpunit/tests/widgets/custom-html-widget.php b/tests/phpunit/tests/widgets/custom-html-widget.php
@@ -51,7 +51,7 @@ function test_widget() {
 		$args = array(
 			'before_title'  => '<h2>',
 			'after_title'   => "</h2>\n",
-			'before_widget' => '<section>',
+			'before_widget' => '<section id="custom_html-5" class="widget widget_custom_html">',
 			'after_widget'  => "</section>\n",
 		);
 		$instance = array(
@@ -70,7 +70,8 @@ function test_widget() {
 		$this->assertNotEmpty( $this->widget_custom_html_content_args );
 		$this->assertNotEmpty( $this->widget_text_args );
 		$this->assertContains( '[filter:widget_text][filter:widget_custom_html_content]', $output );
-		$this->assertContains( '<div class="textwidget custom-html-widget">', $output );
+		$this->assertContains( '<section id="custom_html-5" class="widget_text widget widget_custom_html">', $output );
+		$this->assertContains( 'class="widget_text widget widget_custom_html"', $output );
 		$this->assertNotContains( '<p>', $output );
 		$this->assertNotContains( '<br>', $output );
 		$this->assertNotContains( '</u>', $output );
