Widgets: Improve theme styling compatibility for Custom HTML widget by adding container with textwidget class.

westonruter · westonruter · commit 642693bb916f · 2017-07-21T18:12:43.000Z
The same styling from the Text widget should apply to the Custom HTML widget since users are expected to copy HTML from the (legacy) Text widget into the latter. Amends [40893]. See #40907. Fixes #41392. git-svn-id: https://develop.svn.wordpress.org/trunk@41115 602fd350-edb4-49c9-b593-d223f7449a82
diff --git a/src/wp-includes/widgets/class-wp-widget-custom-html.php b/src/wp-includes/widgets/class-wp-widget-custom-html.php
@@ -79,7 +79,9 @@ public function widget( $args, $instance ) {
 		if ( ! empty( $title ) ) {
 			echo $args['before_title'] . $title . $args['after_title'];
 		}
+		echo '<div class="textwidget custom-html-widget">'; // The textwidget class is for theme styling compatibility.
 		echo $content;
+		echo '</div>';
 		echo $args['after_widget'];
 	}
 
diff --git a/tests/phpunit/tests/widgets/custom-html-widget.php b/tests/phpunit/tests/widgets/custom-html-widget.php
@@ -70,6 +70,7 @@ function test_widget() {
 		$this->assertNotEmpty( $this->widget_custom_html_content_args );
 		$this->assertNotEmpty( $this->widget_text_args );
 		$this->assertContains( '[filter:widget_text][filter:widget_custom_html_content]', $output );
+		$this->assertContains( '<div class="textwidget custom-html-widget">', $output );
 		$this->assertNotContains( '<p>', $output );
 		$this->assertNotContains( '<br>', $output );
 		$this->assertNotContains( '</u>', $output );

Original file line number	Diff line number	Diff line change
`@@ -79,7 +79,9 @@ public function widget( $args, $instance ) {`
`79`	`79`	`if ( ! empty( $title ) ) {`
`80`	`80`	`echo $args['before_title'] . $title . $args['after_title'];`
`81`	`81`	`}`
	`82`	`+ echo '<div class="textwidget custom-html-widget">'; // The textwidget class is for theme styling compatibility.`
`82`	`83`	`echo $content;`
	`84`	`+ echo '</div>';`
`83`	`85`	`echo $args['after_widget'];`
`84`	`86`	`}`
`85`	`87`