Skip to content

Use modern v8 APIs#3

Merged
mgren merged 2 commits into
masterfrom
feature/modern-v8
Oct 2, 2019
Merged

Use modern v8 APIs#3
mgren merged 2 commits into
masterfrom
feature/modern-v8

Conversation

@mgren

@mgren mgren commented Sep 26, 2019

Copy link
Copy Markdown

Stop using v8 APIs deprecated around engine version 4.3 and switch to modern equivalents.

node-compress-buffer-test
✔ basic compress
✔ basic uncompress
✔ compress with compression levels
✔ string exceptions
✔ compress short
✔ errors

OK: 11 assertions (11ms)

Tested on node v6.9, v8, v10, v12, but even earlier node version compatibility might be broken, hence new major version.

@albert-lacki

Copy link
Copy Markdown
Member

👍

@kuebk

kuebk commented Sep 30, 2019

Copy link
Copy Markdown
Member

Nice.

@mgren mgren marked this pull request as ready for review October 2, 2019 07:45
@mgren mgren merged commit 8abf5b9 into master Oct 2, 2019
@jbienkowski311 jbienkowski311 deleted the feature/modern-v8 branch October 16, 2019 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants