Skip to content

Commit e6d9150

Browse files
committed
On branch java8
Changes to be committed: modified: ../DefaultGlobalModel.java modified: CompilerOptions.java Changed the compiler options to specify source and target are Java 8.
1 parent 17c0881 commit e6d9150

File tree

2 files changed

+15
-12
lines changed

2 files changed

+15
-12
lines changed

drjava/src/edu/rice/cs/drjava/model/DefaultGlobalModel.java

Lines changed: 12 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -182,9 +182,10 @@ public DefaultGlobalModel() {
182182
Iterable<? extends JDKToolsLibrary> tools = findLibraries(); // findLibraries should be called findTools
183183
List<CompilerInterface> compilers = new LinkedList<CompilerInterface>();
184184

185-
// TODO: should this be done a different way?
186-
JavaxToolsCompiler javaxCompiler = new JavaxToolsCompiler();
187-
compilers.add(javaxCompiler);
185+
/* Removed in Java 8 version of DrJava */
186+
// // TODO: should this be done a different way?
187+
// JavaxToolsCompiler javaxCompiler = new JavaxToolsCompiler();
188+
// compilers.add(javaxCompiler);
188189

189190
/* Note: the only debugger used in DrJava is JPDADebugger in the DrJava code base which relies
190191
* on machinery provided by the tools.jar library included in every Java JDK (up through JDK 8). A copy of the
@@ -357,15 +358,14 @@ private Iterable<JDKToolsLibrary> findLibraries() {
357358
else { JDKToolsLibrary.msg("\tduplicate"); }
358359
}
359360

360-
/* Removed when OPEN JDK 8 tools.jar (unjarred) was added to drjava.jar */
361-
// // Only create a default JDKToolslibrary for the embedded tools.jar file if the list of results is otherwise empty.
362-
//
363-
// if (results.isEmpty()) {
364-
// JDKToolsLibrary defaultLibrary =
365-
// JarJDKToolsLibrary.makeFromFile(FileOps.getDrJavaFile(), this, JDKDescriptor.JDK_DEFAULT);
366-
// JDKToolsLibrary.msg("Returning default library: " + defaultLibrary);
367-
// return IterUtil.singleton(defaultLibrary);
368-
// }
361+
// /* Removed when OPEN JDK 8 tools.jar (unjarred) was added to drjava.jar */
362+
// Only create a default JDKToolslibrary for the embedded tools.jar file if the list of results is otherwise empty.
363+
if (results.isEmpty()) {
364+
JDKToolsLibrary defaultLibrary =
365+
JarJDKToolsLibrary.makeFromFile(FileOps.getDrJavaFile(), this, JDKDescriptor.JDK_DEFAULT);
366+
JDKToolsLibrary.msg("Returning default library: " + defaultLibrary);
367+
return IterUtil.singleton(defaultLibrary);
368+
}
369369

370370
// Add embedded tools.jar (unjarred) to libraries
371371
JDKToolsLibrary defaultLibrary = JarJDKToolsLibrary.makeFromFile(FileOps.getDrJavaFile(), this, JDKDescriptor.JDK_DEFAULT);

drjava/src/edu/rice/cs/drjava/model/compiler/CompilerOptions.java

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -103,6 +103,9 @@ public static HashMap<String,String> getOptions(boolean warningsEnabled) {
103103
}
104104

105105
//Add any other options we want to add to the compiler in the future
106+
options.put("-source", "8");
107+
options.put("-target", "8");
108+
106109
return options;
107110
}
108111
}

0 commit comments

Comments
 (0)