Added the "-Xlint" option to javax.tools.compiler tasks to get complete diagnostics generated by that compiler (which are more extensive in later versions of Java than those

ponderosaTX · ponderosaTX · commit 17c0881ccf85 · 2024-12-07T00:50:02.000-06:00
generated by the familiar Java 8 compiler.

 Changes to be committed:
	modified:   CompilerOptions.java
	modified:   JavaxToolsCompiler.java
diff --git a/drjava/src/edu/rice/cs/drjava/model/compiler/CompilerOptions.java b/drjava/src/edu/rice/cs/drjava/model/compiler/CompilerOptions.java
@@ -74,6 +74,7 @@ public static void updateWarnings() {
   
   public static HashMap<String,String> getOptions(boolean warningsEnabled) {    
     HashMap<String,String> options = new HashMap<String,String>();
+    
     if (warningsEnabled) {
       if (SHOW_UNCHECKED) {
         options.put("-Xlint:unchecked","");
@@ -97,7 +98,7 @@ public static HashMap<String,String> getOptions(boolean warningsEnabled) {
       
       if (SHOW_FALLTHROUGH) {
         options.put("-Xlint:fallthrough","");
-        options.put("-Xlint:switchcheck",""); //Some compilers appear to use this option instead. Anyone know anything about this?
+//        options.put("-Xlint:switchcheck",""); //Some compilers appear to use this option instead. Anyone know anything about this?
       }
     }
     
diff --git a/drjava/src/edu/rice/cs/drjava/model/compiler/JavaxToolsCompiler.java b/drjava/src/edu/rice/cs/drjava/model/compiler/JavaxToolsCompiler.java
@@ -68,6 +68,7 @@ public List<? extends DJError> compile(List<? extends File> files, List<? extend
         // Prepare the compilation options
         /* Question (by Corky): is the "-source" option necessary?  The JavaxTools compiler is part of the executing JVM. */
         List<String> optionList = new ArrayList<>();
+        optionList.add("-Xlint");
         if (sourceVersion != null) {
             optionList.add("-source");
             optionList.add(sourceVersion);

Original file line number	Diff line number	Diff line change
`@@ -74,6 +74,7 @@ public static void updateWarnings() {`
`74`	`74`
`75`	`75`	`public static HashMap<String,String> getOptions(boolean warningsEnabled) {`
`76`	`76`	`HashMap<String,String> options = new HashMap<String,String>();`
	`77`	`+`
`77`	`78`	`if (warningsEnabled) {`
`78`	`79`	`if (SHOW_UNCHECKED) {`
`79`	`80`	`options.put("-Xlint:unchecked","");`
`@@ -97,7 +98,7 @@ public static HashMap<String,String> getOptions(boolean warningsEnabled) {`
`97`	`98`
`98`	`99`	`if (SHOW_FALLTHROUGH) {`
`99`	`100`	`options.put("-Xlint:fallthrough","");`
`100`		`- options.put("-Xlint:switchcheck",""); //Some compilers appear to use this option instead. Anyone know anything about this?`
	`101`	`+// options.put("-Xlint:switchcheck",""); //Some compilers appear to use this option instead. Anyone know anything about this?`
`101`	`102`	`}`
`102`	`103`	`}`
`103`	`104`