This repository was archived by the owner on Mar 20, 2019. It is now read-only.
Allow to add or replace MessagePart converters from outside#30
Open
derigel23 wants to merge 1 commit intoDotNetOpenAuth:v3.4from
Open
Allow to add or replace MessagePart converters from outside#30derigel23 wants to merge 1 commit intoDotNetOpenAuth:v3.4from
derigel23 wants to merge 1 commit intoDotNetOpenAuth:v3.4from
Conversation
Member
|
Wow. You've obviously spent some time studying our DNOA's messaging framework works. This is a good candidate for pulling in. We do have a mutable MessageDescription system in the osis branch (since tests have to deliberately break stuff on occasion), so I'll review that one with this one and see if this is the best way to go. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I need to use custom OAuth provider which is not following standards. Instead of 'true' or 'false' for boolean values it uses '1' and '0'. If I replace bool.Parse to XmlConvert.ToBoolean (which can handle both '1' , '0' and 'true', 'fase') I will be fine. But I can't do this without dotnetopenauth project recompilation (which is hard with signing stuff).
This patch will allow to replace standard converters.
For example, for my case:
MessagePart.Map(value => value ? "1" : "0", null, XmlConvert.ToBoolean);