Update the variable syntax in configurationSnippets - #980
Merged
DonJayamanne merged 1 commit intoMay 24, 2017
Conversation
…ables are not improperly substituted. For example, $${{config:python.pythonPath}} turned into $python.pythonPath} which is missing the "{config:". This commit removes the tabstops in the configurationSnippets.
Also, created configurationSnippet for Pyramid apps.
Goom11
pushed a commit
to mostafaeweda/pythonVSCode
that referenced
this pull request
Aug 30, 2018
…onJayamanne#1649) * Ensure the prompt to install missing packages is displayed only once * Add missing dependency * Fixes DonJayamanne#980
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The variable syntax change introduced in Issue #774 caused a conflict with snippet variable substitution in the configurationSnippets. For example,
$${{config:python.pythonPath}}was turned into$python.pythonPath}instead of${config:python.pythonPath}when using the Python configuration snippet.I used the syntax found in the example debugger to preserve the pythonVSCode variables within the configurationSnippets.
Note that this change removes the tabstops in the configurationSnippets. If the tabstops are desired, the following syntax could be used instead:
"^\"${1:\\${config:python.pythonPath\\}}\""I also added a configurationSnippet for Pyramid apps since it wasn't already there.