allocation now modifies quantity state in place

hjwp · hjwp · commit 5a79e53618f6 · 2019-02-05T10:15:06.000Z
diff --git a/domain_model.py b/domain_model.py
@@ -30,6 +30,7 @@ def allocate_to(line, allocation, quantities):
     for quantity in quantities:
         if quantity.sku == line.sku and quantity.quantity > line.quantity:
             line.allocation = allocation
+            quantity.quantity -= line.quantity
             return
 
 def allocate_to_stock(line, stock):
@@ -51,7 +52,9 @@ def allocate(order, stock, shipments):
         for line in order:
             allocate_to_stock(line, stock)
         return
+
     shipments.sort(key=lambda s: s.eta)
+
     for shipment in shipments:
         if skus(order) <= skus(shipment):
             for line in order:
diff --git a/test_allocation.py b/test_allocation.py
@@ -232,3 +232,14 @@ def test_cannot_allocate_if_insufficent_quantity_in_shipment():
 
     assert order[0].allocation is None
 
+
+def test_allocation_decreases_quantity_available_on_shipments():
+    order1 = [OrderLine(sku='a-sku', quantity=10)]
+    order2 = [OrderLine(sku='a-sku', quantity=10)]
+    stock = [Line(sku='a-sku', quantity=15)]
+
+    allocate(order1, stock, shipments=[])
+    allocate(order2, stock, shipments=[])
+
+    assert order2[0].allocation is None
+
