allocation checks basic quantity

hjwp · hjwp · commit 14e27e51fb4d · 2019-02-05T10:15:06.000Z
diff --git a/domain_model.py b/domain_model.py
@@ -26,28 +26,36 @@ def skus(thing):
         return {line.sku for line in thing.lines}
 
 
+def allocate_to(line, allocation, quantities):
+    for quantity in quantities:
+        if quantity.sku == line.sku and quantity.quantity > line.quantity:
+            line.allocation = allocation
+            return
 
 def allocate_to_stock(line, stock):
-    for stock_line in stock:
-        if stock_line.sku == line.sku:
-            line.allocation = 'STOCK'
+    allocate_to(line, 'STOCK', stock)
+
+def allocate_to_shipment(line, shipment):
+    allocate_to(line, shipment.id, shipment.lines)
+
 
 def allocate_to_shipments(line, shipments):
     for shipment in shipments:
-        for shipment_line in shipment.lines:
-            if shipment_line.sku == line.sku:
-                line.allocation = shipment.id
+        allocate_to_shipment(line, shipment)
+        if line.allocation is not None:
+            return
+
 
 def allocate(order, stock, shipments):
     if skus(order) <= skus(stock):
         for line in order:
-            line.allocation = 'STOCK'
+            allocate_to_stock(line, stock)
         return
     shipments.sort(key=lambda s: s.eta)
     for shipment in shipments:
         if skus(order) <= skus(shipment):
             for line in order:
-                line.allocation = shipment.id
+                allocate_to(line, shipment.id, shipment.lines)
             return
 
     for line in order:
diff --git a/test_allocation.py b/test_allocation.py
@@ -212,3 +212,23 @@ def test_prefer_allocating_to_earlier_even_if_multiple_shipments():
     assert order[1].allocation == shipment2.id
     assert order[2].allocation == shipment2.id
 
+
+def test_cannot_allocate_if_insufficent_quantity_in_stock():
+    order = [OrderLine(sku='a-sku', quantity=10)]
+    stock = [Line(sku='a-sku', quantity=5)]
+
+    allocate(order, stock, shipments=[])
+
+    assert order[0].allocation is None
+
+
+def test_cannot_allocate_if_insufficent_quantity_in_shipment():
+    order = [OrderLine(sku='a-sku', quantity=10)]
+    shipment = Shipment(id='shipment-id', eta=date.today(), lines=[
+        Line(sku='a-sku', quantity=5),
+    ])
+
+    allocate(order, stock=[], shipments=[shipment])
+
+    assert order[0].allocation is None
+
