Added async io, action until keyup#112
Closed
casten wants to merge 2 commits intoDexterInd:masterfrom
Closed
Conversation
Contributor
|
Hi casten, So, I took your example, modified it a bit and made a new project folder for it here #114 . Do try it and let me know if it looks good and feel free to make changes to it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I had wished the example controller stopped the action when you released the key. This is via the pygame library which seems to be preinstalled on my GoPiGo. Since keyup triggers stop, I removed the stop key handling. Finally, since I'm using a blocking call, no repl style interface is needed, so I think that is a little cleaner.
It seems to work pretty well.